[ash-md] Applied Material Design layout to TrayItemMore system menu rows.

ash/common/system/tray/tray_popup_utils.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_UTIL_H_

[tdanderson, 2016/11/01 18:59:44]

nit: UTILS_H_ rather than UTIL_H_

[bruthig, 2016/11/01 23:00:43]

Done.

+#define ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_UTIL_H_
+
+#include "ash/common/system/tray/tri_view.h"
+#include "base/strings/string16.h"
+
+namespace views {
+class ButtonListener;
+class ImageView;
+class Label;
+class LabelButton;
+class LayoutManager;
+class Slider;
+class SliderListener;
+}  // namespace views
+
+namespace ash {
+
+// Factory/utility functions used by the system menu.
+class TrayPopupUtils {
+ public:
+  // Creates a default container view to be used most system menu rows. The
+  // caller takes over ownership of the created view.
+  //
+  // The returned view consists of 3 regions: START, CENTER, and END. Any child
+  // Views added to the START and END containers will be added horizonatlly and
+  // any Views added to the CENTER container will be added vertically.
+  //
+  // The START and END containers have a fixed width but can grow into the
+  // CENTER container if space is required and available.
+  //
+  // The CENTER container has a flexible width.
+  static TriView* CreateDefaultRowView();
+
+  // Creates the default layout manager by CreateDefault() row for the given
+  // |container|. To be used when mutliple targetable areas are required within
+  // a single row.
+  static std::unique_ptr<views::LayoutManager> CreateLayoutManager(
+      TriView::Container container);
+
+  // Returns a label that has been configured for system menu layout.

[tdanderson, 2016/11/01 18:59:44]

Similar to the comments I made in the constants file, can you please clarify in
the documentation for CreateDefaultLabel(), CreateMainImageView(), and Create
MoreImageView() if they are to be used only by default menu rows. Specifically,
it would be good to make it clear for everyone whether or not these can be used
for the rows in the detailed views (e.g., the rows for each available Bluetooth
device).

[bruthig, 2016/11/01 23:00:43]

Done.

+  //
+  // TODO(bruthig): Update all system menu rows to use this.
+  static views::Label* CreateDefaultLabel();
+
+  // Returns an image view to be used for the main image of a system menu row.
+  //
+  // TODO(bruthig): Update all system menu rows to use this.
+  static views::ImageView* CreateMainImageView();
+
+  // Returns an image view to be used for the 'more' arrow image on default
+  // rows.
+  //
+  // TODO(bruthig): Update all default rows to use this.
+  static views::ImageView* CreateMoreImageView();
+
+ private:
+  TrayPopupUtils() = delete;
+  ~TrayPopupUtils() = delete;
+
+  // Configures the specified |container| view with the default layout. Used by
+  // CreateDefaultRowView().
+  static void ConfigureDefaultLayout(TriView* tri_view,
+                                     TriView::Container container);
+};
+
+}  // namespace ash
+
+#endif  // ASH_COMMON_SYSTEM_TRAY_TRAY_POPUP_UTIL_H_