Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: media/formats/mp4/mp4_stream_parser_unittest.cc

Issue 246853005: Fix SPS/PPS insertion logic in MP4StreamParser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « media/formats/mp4/mp4_stream_parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 512)); 205 512));
206 } 206 }
207 207
208 // Test an invalid file where there are encrypted samples, but 208 // Test an invalid file where there are encrypted samples, but
209 // SampleAuxiliaryInformation{Sizes|Offsets}Box (saiz|saio) are missing. 209 // SampleAuxiliaryInformation{Sizes|Offsets}Box (saiz|saio) are missing.
210 // The parser should fail instead of crash. See http://crbug.com/361347 210 // The parser should fail instead of crash. See http://crbug.com/361347
211 TEST_F(MP4StreamParserTest, MissingSampleAuxInfo) { 211 TEST_F(MP4StreamParserTest, MissingSampleAuxInfo) {
212 ParseMP4File("bear-1280x720-a_frag-cenc_missing-saiz-saio.mp4", 512); 212 ParseMP4File("bear-1280x720-a_frag-cenc_missing-saiz-saio.mp4", 512);
213 } 213 }
214 214
215 // Test a file where all video samples start with an Access Unit
216 // Delimiter (AUD) NALU.
217 TEST_F(MP4StreamParserTest, VideoSamplesStartWithAUDs) {
218 ParseMP4File("bear-1280x720-av_with-aud-nalus_frag.mp4", 512);
219 }
220
215 // TODO(strobe): Create and test media which uses CENC auxiliary info stored 221 // TODO(strobe): Create and test media which uses CENC auxiliary info stored
216 // inside a private box 222 // inside a private box
217 223
218 } // namespace mp4 224 } // namespace mp4
219 } // namespace media 225 } // namespace media
OLDNEW
« no previous file with comments | « media/formats/mp4/mp4_stream_parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698