third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js - Issue 2468493004: DevTools: Consolidate completion code into JavaScriptAutocomplete.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

Issue 2468493004: DevTools: Consolidate completion code into JavaScriptAutocomplete.js (Closed)

Patch Set: merge Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/module.json ('k') | third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

index 6ab4ec7a32c4698bc2bc52cd3a80814f172eeabc..446623988581e38799086092474a3eff4b421ee1 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js

@@ -274,7 +274,7 @@ WebInspector.ConsolePrompt.prototype = {

var prefix = this._editor.text(prefixRange);

var before = this._editor.text(new WebInspector.TextRange(0, 0, prefixRange.startLine, prefixRange.startColumn));

var historyWords = this._historyCompletions(prefix);

- return WebInspector.ExecutionContextSelector.completionsForTextInCurrentContext(before, prefix, true /* force */).then(innerWordsWithPrefix);

+ return WebInspector.JavaScriptAutocomplete.completionsForTextInCurrentContext(before, prefix, true /* force */).then(innerWordsWithPrefix);

/**

* @param {!Array<string>} words