Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js

Issue 2468493004: DevTools: Consolidate completion code into JavaScriptAutocomplete.js (Closed)
Patch Set: merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js b/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
index c7d3d914acf015d89daa96acd6a85af098d61a75..6c7f6e3fa2c2eb4dcf4b1f5bac50d72de5535a1b 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js
@@ -213,55 +213,3 @@ WebInspector.ExecutionContextSelector.prototype = {
this._ignoreContextChanged = false;
}
};
-
-/**
- * @param {!Element} proxyElement
- * @param {!Range} wordRange
- * @param {boolean} force
- * @param {function(!Array.<string>, number=)} completionsReadyCallback
- */
-WebInspector.ExecutionContextSelector.completionsForTextPromptInCurrentContext = function(proxyElement, wordRange, force, completionsReadyCallback)
-{
- var expressionRange = wordRange.cloneRange();
- expressionRange.collapse(true);
- expressionRange.setStartBefore(proxyElement);
- WebInspector.ExecutionContextSelector.completionsForTextInCurrentContext(expressionRange.toString(), wordRange.toString(), force).then(completionsReadyCallback);
-};
-/**
- * @param {string} text
- * @param {string} completionsPrefix
- * @param {boolean=} force
- * @return {!Promise<!Array<string>>}
- */
-WebInspector.ExecutionContextSelector.completionsForTextInCurrentContext = function(text, completionsPrefix, force)
-{
- var executionContext = WebInspector.context.flavor(WebInspector.ExecutionContext);
- if (!executionContext)
- return Promise.resolve([]);
- var index;
- var stopChars = new Set(" =:({;,!+-*/&|^<>`".split(""));
- for (index = text.length - 1; index >= 0; index--) {
- // Pass less stop characters to rangeOfWord so the range will be a more complete expression.
- if (stopChars.has(text.charAt(index)))
- break;
- }
- var clippedExpression = text.substring(index + 1);
- var bracketCount = 0;
-
- index = clippedExpression.length - 1;
- while (index >= 0) {
- var character = clippedExpression.charAt(index);
- if (character === "]")
- bracketCount++;
- // Allow an open bracket at the end for property completion.
- if (character === "[" && index < clippedExpression.length - 1) {
- bracketCount--;
- if (bracketCount < 0)
- break;
- }
- index--;
- }
- clippedExpression = clippedExpression.substring(index + 1);
-
- return executionContext.completionsForExpression(clippedExpression, completionsPrefix, force);
-};

Powered by Google App Engine
This is Rietveld 408576698