Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2468493003: Type-related fixes (Closed)

Created:
4 years, 1 month ago by vsm
Modified:
4 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vsm
4 years, 1 month ago (2016-10-31 17:34:29 UTC) #2
Jennifer Messerly
lgtm
4 years, 1 month ago (2016-10-31 21:58:08 UTC) #3
vsm
4 years, 1 month ago (2016-10-31 22:01:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d15b4ae74e1bd992425518e334606558e001914 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698