Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2468473002: Don't do a callback when suppressing a dialog. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't do a callback when suppressing a dialog. Running the callback is already handled by the calling WebContents in that case. BUG=629964 Committed: https://crrev.com/25a3897a86b1a6b8932b92d1a1901789366d841c Cr-Commit-Position: refs/heads/master@{#428758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/javascript_dialogs/javascript_dialog_tab_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Avi (use Gerrit)
4 years, 1 month ago (2016-10-31 16:29:18 UTC) #4
nasko
LGTM
4 years, 1 month ago (2016-10-31 18:34:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468473002/1
4 years, 1 month ago (2016-10-31 18:37:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 18:42:45 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 18:47:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25a3897a86b1a6b8932b92d1a1901789366d841c
Cr-Commit-Position: refs/heads/master@{#428758}

Powered by Google App Engine
This is Rietveld 408576698