Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2468443002: remove deprecated skia transfer mode usage (Closed)

Created:
4 years, 1 month ago by caryclark
Modified:
4 years, 1 month ago
Reviewers:
dsinclair, reed1
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

remove deprecated skia transfer mode usage Skia has removed transfer modes as a class, and made it an enum. Update PDFium to match. R=reed@google.com,dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fea997eb29e08a85038b5fc3b14bcaa35da369e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
caryclark
4 years, 1 month ago (2016-10-31 15:06:59 UTC) #1
reed1
lgtm
4 years, 1 month ago (2016-10-31 15:08:04 UTC) #4
dsinclair
lgtm
4 years, 1 month ago (2016-10-31 15:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468443002/1
4 years, 1 month ago (2016-10-31 15:23:10 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 15:23:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/fea997eb29e08a85038b5fc3b14bcaa35da3...

Powered by Google App Engine
This is Rietveld 408576698