Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2468433002: Minor fixes in objects printer. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor fixes in objects printer. BUG= Committed: https://crrev.com/9dd638fe704c760982163a4410e6ce285bd51ca0 Cr-Commit-Position: refs/heads/master@{#40674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/objects-printer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-31 14:44:40 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-10-31 14:48:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468433002/1
4 years, 1 month ago (2016-10-31 14:49:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 15:16:20 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dd638fe704c760982163a4410e6ce285bd51ca0
Cr-Commit-Position: refs/heads/master@{#40674}

Powered by Google App Engine
This is Rietveld 408576698