Issue 246843006: mesa: Disable use of "pragma export" on OS X. clang doesn't understand it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246843006: mesa: Disable use of "pragma export" on OS X. clang doesn't understand it. (Closed)

Created:
6 years, 8 months ago by Nico

Modified:
6 years, 8 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Ken Russell (switch to Gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/mesa/

Visibility:
Public.

mesa: Disable use of "pragma export" on OS X. clang doesn't understand it. Filed upstream as crbug.com/365682 . The motivation is to let mesa no longer push -Wno-unknown-pragmas to all targets that depend on mesa. We used to have this change, but https://codereview.chromium.org/17005007 lost it. BUG=338759 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265279

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	include/GL/gl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	include/GL/osmesa.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

(I'm aware you just landed that change and didn't write or review it.)

6 years, 8 months ago (2014-04-22 16:30:59 UTC) #1

Nico

6 years, 8 months ago (2014-04-22 16:38:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r265279 (presubmit successful).