Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2468423009: Remove plugins::MobileYouTubePlugin, deprecated by Flash embed override. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove plugins::MobileYouTubePlugin, deprecated by Flash embed override. We know rewrite all YouTube flash embeds to HTML5 on all platforms, making the Chrome Android specific plugin replacement deprecated. BUG=654529 Committed: https://crrev.com/d66fde4d6680319d8dc43725fda48857ab2113a9 Cr-Commit-Position: refs/heads/master@{#431797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -242 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +2 lines, -13 lines 0 comments Download
D chrome/renderer/resources/plugins/mobile_youtube_plugin.html View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M components/plugins/renderer/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D components/plugins/renderer/mobile_youtube_plugin.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mlamouri (slow - plz ping)
jochen@ for OWNERS tedchoc@ for Chrome Android ownership.
4 years, 1 month ago (2016-11-04 20:03:16 UTC) #4
Ted C
lgtm
4 years, 1 month ago (2016-11-04 22:50:26 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-12 23:08:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468423009/1
4 years, 1 month ago (2016-11-12 23:11:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-13 00:15:15 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-13 00:17:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d66fde4d6680319d8dc43725fda48857ab2113a9
Cr-Commit-Position: refs/heads/master@{#431797}

Powered by Google App Engine
This is Rietveld 408576698