Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2468423008: Fix memory leak in test-scanner.cc. (Closed)

Created:
4 years, 1 month ago by vogelheim
Modified:
4 years, 1 month ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix memory leak in test-scanner.cc. BUG=chromium:662388 Committed: https://crrev.com/3019b49764c652ed2e894def25f480ad724cd68a Cr-Commit-Position: refs/heads/master@{#40781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M test/cctest/parsing/test-scanner.cc View 4 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
vogelheim
ptal.
4 years, 1 month ago (2016-11-04 17:41:43 UTC) #4
ahaas
lgtm
4 years, 1 month ago (2016-11-04 18:48:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468423008/1
4 years, 1 month ago (2016-11-04 18:51:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 18:53:46 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3019b49764c652ed2e894def25f480ad724cd68a
Cr-Commit-Position: refs/heads/master@{#40781}

Powered by Google App Engine
This is Rietveld 408576698