Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2468423004: Left side vertical MD scrollbars grow toward right. (Closed)

Created:
4 years, 1 month ago by sahel
Modified:
4 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Left side vertical MD scrollbars grow toward right. This patch plumbs through the is_overlay and is_left_side_vertical_scrollbar flags for painted scrollbar layers. BUG=661259 TEST=ScrollbarLayerTest.ThumbRectForOverlayLeftSideVerticalScrollbar CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d Cr-Commit-Position: refs/heads/master@{#430019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -25 lines) Patch
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.h View 2 chunks +9 lines, -3 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M cc/test/fake_painted_scrollbar_layer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/test/fake_painted_scrollbar_layer.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M cc/test/fake_scrollbar.h View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/test/fake_scrollbar.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/test/layer_test_common.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
sahel
Please review the cl asap.
4 years, 1 month ago (2016-11-04 15:04:52 UTC) #8
bokan
Please expand the description to mention what this patch is doing. (Plumbing through the is_overlay ...
4 years, 1 month ago (2016-11-04 19:09:18 UTC) #9
sahel
aelias@chromium.org: Please review changes in
4 years, 1 month ago (2016-11-04 19:56:40 UTC) #12
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-04 20:08:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468423004/1
4 years, 1 month ago (2016-11-04 20:25:23 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 21:22:52 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 21:24:23 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d
Cr-Commit-Position: refs/heads/master@{#430019}

Powered by Google App Engine
This is Rietveld 408576698