Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2468423002: Update usage of mx_handle_wait_many() API. (Closed)

Created:
4 years, 1 month ago by jeffbrown
Modified:
4 years, 1 month ago
Reviewers:
abarth, zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update usage of mx_handle_wait_many() API. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -60 lines) Patch
M runtime/bin/eventhandler_fuchsia.h View 2 chunks +2 lines, -4 lines 2 comments Download
M runtime/bin/eventhandler_fuchsia.cc View 1 9 chunks +24 lines, -56 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jeffbrown
Is there a way to test this? (Any apps using the dart content handler?)
4 years, 1 month ago (2016-11-03 04:27:16 UTC) #2
abarth
4 years, 1 month ago (2016-11-03 04:38:22 UTC) #4
abarth
On 2016/11/03 at 04:27:16, jeffbrown wrote: > Is there a way to test this? (Any ...
4 years, 1 month ago (2016-11-03 04:40:00 UTC) #5
jeffbrown
/boot/apps/hello_fuchsia.dart runs, so I'll take it as a good sign. Ready for review.
4 years, 1 month ago (2016-11-03 05:26:19 UTC) #6
abarth
lgtm
4 years, 1 month ago (2016-11-03 05:29:23 UTC) #7
zra
lgtm https://codereview.chromium.org/2468423002/diff/20001/runtime/bin/eventhandler_fuchsia.h File runtime/bin/eventhandler_fuchsia.h (right): https://codereview.chromium.org/2468423002/diff/20001/runtime/bin/eventhandler_fuchsia.h#newcode80 runtime/bin/eventhandler_fuchsia.h:80: mx_handle_t* handles_; It looks like you can also ...
4 years, 1 month ago (2016-11-03 05:48:21 UTC) #8
abarth-chromium
Committed patchset #2 (id:20001) manually as 46c326fae353c795462ecb63de8d254d49640a38.
4 years, 1 month ago (2016-11-03 05:48:22 UTC) #10
jeffbrown
4 years, 1 month ago (2016-11-03 05:56:07 UTC) #11
Message was sent while issue was closed.
Thanks for catching that Zach.

Fixed over here: https://codereview.chromium.org/2479453002/

https://codereview.chromium.org/2468423002/diff/20001/runtime/bin/eventhandle...
File runtime/bin/eventhandler_fuchsia.h (right):

https://codereview.chromium.org/2468423002/diff/20001/runtime/bin/eventhandle...
runtime/bin/eventhandler_fuchsia.h:80: mx_handle_t* handles_;
On 2016/11/03 05:48:21, zra wrote:
> It looks like you can also remove handles_

whoops!

Powered by Google App Engine
This is Rietveld 408576698