Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2468413005: Implement local storage for App List in case app sync is off. (Closed)

Created:
4 years, 1 month ago by khmel
Modified:
4 years, 1 month ago
Reviewers:
reviewer
CC:
chromium-reviews, tfarina, sadrul, Matt Giuca, sync-reviews_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement local storage for App List in case app sync is off. This CL keeps local copy of current app list service and in case app sync is off, date from local storage is used to init app list model. Once sync is resumed, local copy is overriden and information form sync is used. BUG=641535 TEST=Unit and sync tests added TEST=Manually on device. TBR=reviewer@chromium.org Reland: http://crrev.com/2416133002 (cherry picked from commit f06c029695e6d3a62ea950c1ba0f60cf01c353a8) Review-Url: https://codereview.chromium.org/2416133002 Committed: https://crrev.com/eca5057f03c04b7dbb0764fa090aac36fbd9731c Cr-Original-Commit-Position: refs/heads/master@{#427390} Cr-Commit-Position: refs/heads/master@{#429621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -31 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 3 chunks +117 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.h View 6 chunks +25 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 24 chunks +150 lines, -28 lines 0 comments Download
M chrome/browser/ui/ash/chrome_launcher_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468413005/1
4 years, 1 month ago (2016-11-03 15:56:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468413005/1
4 years, 1 month ago (2016-11-03 16:11:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 16:55:12 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:13:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eca5057f03c04b7dbb0764fa090aac36fbd9731c
Cr-Commit-Position: refs/heads/master@{#429621}

Powered by Google App Engine
This is Rietveld 408576698