Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2468403003: Remove stl_util's deletion function use from cocoa content_settings. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from cocoa content_settings. BUG=555865 Committed: https://crrev.com/34ee46a942edd23a83c1fd3cb80c5bb47c37dffe Cr-Commit-Position: refs/heads/master@{#429651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 5 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Avi (use Gerrit)
4 years, 1 month ago (2016-11-03 15:38:00 UTC) #4
Robert Sesek
LGTM
4 years, 1 month ago (2016-11-03 16:44:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468403003/1
4 years, 1 month ago (2016-11-03 18:16:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 18:21:55 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:45:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34ee46a942edd23a83c1fd3cb80c5bb47c37dffe
Cr-Commit-Position: refs/heads/master@{#429651}

Powered by Google App Engine
This is Rietveld 408576698