Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Side by Side Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

Issue 2468403002: Make WebBluetooth chooser consistent on Android and desktops (desktop part) (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h" 5 #include "chrome/browser/ui/views/extensions/chooser_dialog_view.h"
6 6
7 #include <memory>
8
7 #include "base/macros.h" 9 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/chooser_controller/mock_chooser_controller.h" 11 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
10 #include "chrome/browser/ui/views/chooser_content_view.h" 12 #include "chrome/browser/ui/views/chooser_content_view.h"
11 #include "chrome/grit/generated_resources.h" 13 #include "chrome/grit/generated_resources.h"
12 #include "testing/gmock/include/gmock/gmock.h" 14 #include "testing/gmock/include/gmock/gmock.h"
13 #include "ui/base/l10n/l10n_util.h" 15 #include "ui/base/l10n/l10n_util.h"
14 #include "ui/views/controls/button/label_button.h" 16 #include "ui/views/controls/button/label_button.h"
17 #include "ui/views/controls/styled_label.h"
15 #include "ui/views/controls/table/table_view.h" 18 #include "ui/views/controls/table/table_view.h"
16 #include "ui/views/test/views_test_base.h" 19 #include "ui/views/test/views_test_base.h"
17 #include "ui/views/widget/widget.h" 20 #include "ui/views/widget/widget.h"
18 #include "ui/views/window/dialog_client_view.h" 21 #include "ui/views/window/dialog_client_view.h"
19 22
20 class ChooserDialogViewTest : public views::ViewsTestBase { 23 class ChooserDialogViewTest : public views::ViewsTestBase {
21 public: 24 public:
22 ChooserDialogViewTest() {} 25 ChooserDialogViewTest() {}
23 ~ChooserDialogViewTest() override {} 26 ~ChooserDialogViewTest() override {}
24 27
25 // views::ViewsTestBase: 28 // views::ViewsTestBase:
26 void SetUp() override { 29 void SetUp() override {
27 views::ViewsTestBase::SetUp(); 30 views::ViewsTestBase::SetUp();
28 std::unique_ptr<MockChooserController> mock_chooser_controller( 31 std::unique_ptr<MockChooserController> mock_chooser_controller(
29 new MockChooserController(nullptr)); 32 new MockChooserController(nullptr));
30 mock_chooser_controller_ = mock_chooser_controller.get(); 33 mock_chooser_controller_ = mock_chooser_controller.get();
31 std::unique_ptr<ChooserDialogView> chooser_dialog_view( 34 std::unique_ptr<ChooserDialogView> chooser_dialog_view(
32 new ChooserDialogView(std::move(mock_chooser_controller))); 35 new ChooserDialogView(std::move(mock_chooser_controller)));
36 footnote_link_.reset(chooser_dialog_view->chooser_content_view_for_test()
37 ->CreateFootnoteView());
33 chooser_dialog_view_ = chooser_dialog_view.get(); 38 chooser_dialog_view_ = chooser_dialog_view.get();
34 table_view_ = chooser_dialog_view_->chooser_content_view_for_test() 39 table_view_ =
35 ->table_view_for_test(); 40 chooser_dialog_view_->chooser_content_view_for_test()->table_view_;
36 ASSERT_TRUE(table_view_); 41 ASSERT_TRUE(table_view_);
37 dialog_ = views::DialogDelegate::CreateDialogWidget( 42 dialog_ = views::DialogDelegate::CreateDialogWidget(
38 chooser_dialog_view.release(), GetContext(), nullptr); 43 chooser_dialog_view.release(), GetContext(), nullptr);
39 ASSERT_TRUE(dialog_); 44 ASSERT_TRUE(dialog_);
40 ok_button_ = chooser_dialog_view_->GetDialogClientView()->ok_button(); 45 ok_button_ = chooser_dialog_view_->GetDialogClientView()->ok_button();
41 ASSERT_TRUE(ok_button_); 46 ASSERT_TRUE(ok_button_);
42 cancel_button_ = 47 cancel_button_ =
43 chooser_dialog_view_->GetDialogClientView()->cancel_button(); 48 chooser_dialog_view_->GetDialogClientView()->cancel_button();
44 ASSERT_TRUE(cancel_button_); 49 ASSERT_TRUE(cancel_button_);
45 } 50 }
46 51
47 // views::ViewsTestBase: 52 // views::ViewsTestBase:
48 void TearDown() override { 53 void TearDown() override {
49 dialog_->CloseNow(); 54 dialog_->CloseNow();
50 views::ViewsTestBase::TearDown(); 55 views::ViewsTestBase::TearDown();
51 } 56 }
52 57
53 protected: 58 protected:
54 MockChooserController* mock_chooser_controller_; 59 MockChooserController* mock_chooser_controller_;
55 ChooserDialogView* chooser_dialog_view_; 60 ChooserDialogView* chooser_dialog_view_;
61 std::unique_ptr<views::StyledLabel> footnote_link_;
56 views::TableView* table_view_; 62 views::TableView* table_view_;
57 views::LabelButton* ok_button_; 63 views::LabelButton* ok_button_;
58 views::LabelButton* cancel_button_; 64 views::LabelButton* cancel_button_;
59 views::Widget* dialog_; 65 views::Widget* dialog_;
60 66
61 private: 67 private:
62 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest); 68 DISALLOW_COPY_AND_ASSIGN(ChooserDialogViewTest);
63 }; 69 };
64 70
65 TEST_F(ChooserDialogViewTest, InitialState) { 71 TEST_F(ChooserDialogViewTest, InitialState) {
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 EXPECT_TRUE(cancel_button_->enabled()); 372 EXPECT_TRUE(cancel_button_->enabled());
367 table_view_->Select(0); 373 table_view_->Select(0);
368 EXPECT_TRUE(ok_button_->enabled()); 374 EXPECT_TRUE(ok_button_->enabled());
369 EXPECT_TRUE(cancel_button_->enabled()); 375 EXPECT_TRUE(cancel_button_->enabled());
370 376
371 mock_chooser_controller_->OnDiscoveryStateChanged( 377 mock_chooser_controller_->OnDiscoveryStateChanged(
372 content::BluetoothChooser::DiscoveryState::IDLE); 378 content::BluetoothChooser::DiscoveryState::IDLE);
373 EXPECT_TRUE(ok_button_->enabled()); 379 EXPECT_TRUE(ok_button_->enabled());
374 EXPECT_TRUE(cancel_button_->enabled()); 380 EXPECT_TRUE(cancel_button_->enabled());
375 } 381 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698