Make WebBluetooth chooser consistent on Android and desktops (desktop part)

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 #include <vector>
@@ skipping 60 matching lines @@
         chooser_dialog_->chooser_dialog_cocoa_controller_.get();
     ASSERT_TRUE(chooser_dialog_controller_);
     chooser_content_view_ = [chooser_dialog_controller_ chooserContentView];
     ASSERT_TRUE(chooser_content_view_);
     adapter_off_help_button_ = [chooser_content_view_ adapterOffHelpButton];
     ASSERT_TRUE(adapter_off_help_button_);
     table_view_ = [chooser_content_view_ tableView];
     ASSERT_TRUE(table_view_);
     spinner_ = [chooser_content_view_ spinner];
     ASSERT_TRUE(spinner_);
-    status_ = [chooser_content_view_ status];
-    ASSERT_TRUE(status_);
-    rescan_button_ = [chooser_content_view_ rescanButton];
-    ASSERT_TRUE(rescan_button_);
     connect_button_ = [chooser_content_view_ connectButton];
     ASSERT_TRUE(connect_button_);
     cancel_button_ = [chooser_content_view_ cancelButton];
     ASSERT_TRUE(cancel_button_);
     help_button_ = [chooser_content_view_ helpButton];
     ASSERT_TRUE(help_button_);
+    scanning_message_ = [chooser_content_view_ scanningMessage];
+    ASSERT_TRUE(scanning_message_);
+    word_connector_ = [chooser_content_view_ wordConnector];
+    ASSERT_TRUE(word_connector_);
+    rescan_button_ = [chooser_content_view_ rescanButton];
+    ASSERT_TRUE(rescan_button_);
   }
 
   void ExpectNoRowImage(int row) {
     ASSERT_FALSE(
         [chooser_content_view_ tableRowViewImage:static_cast<NSInteger>(row)]);
   }
 
   void ExpectSignalStrengthLevelImageIs(int row,
                                         int expected_signal_strength_level,
                                         int expected_color) {
@@ skipping 53 matching lines @@
   ui::ResourceBundle& rb_;
 
   std::unique_ptr<ChooserDialogCocoa> chooser_dialog_;
 
   MockChooserController* mock_chooser_controller_;
   ChooserDialogCocoaController* chooser_dialog_controller_;
   ChooserContentViewCocoa* chooser_content_view_;
   NSButton* adapter_off_help_button_;
   NSTableView* table_view_;
   SpinnerView* spinner_;
-  NSTextField* status_;
-  NSButton* rescan_button_;
   NSButton* connect_button_;
   NSButton* cancel_button_;
   NSButton* help_button_;
+  NSTextField* scanning_message_;
+  NSTextField* word_connector_;
+  NSButton* rescan_button_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ChooserDialogCocoaControllerTest);
 };
 
 TEST_F(ChooserDialogCocoaControllerTest, InitialState) {
   CreateChooserDialog();
 
   // Since "No devices found." needs to be displayed on the |table_view_|,
   // the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   // No image shown.
   ExpectNoRowImage(0);
   ExpectRowTextIs(
       0, l10n_util::GetNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT));
   EXPECT_FALSE(IsRowPaired(0));
   // |table_view_| should be disabled since there is no option shown.
   EXPECT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   // |connect_button_| should be disabled since no option selected.
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
   EXPECT_TRUE(help_button_.enabled);
-  EXPECT_NSEQ(l10n_util::GetNSString(IDS_DEVICE_CHOOSER_GET_HELP_LINK_TEXT),
+  EXPECT_NSEQ(l10n_util::GetNSStringF(
+                  IDS_DEVICE_CHOOSER_GET_HELP_LINK_WITH_SCANNING_STATUS,
+                  base::string16()),
               help_button_.title);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, AddOption) {
   CreateChooserDialog();
 
   mock_chooser_controller_->OptionAdded(
       base::ASCIIToUTF16("a"),
       MockChooserController::kNoSignalStrengthLevelImage,
       MockChooserController::ConnectedPairedStatus::CONNECTED |
@@ skipping 686 matching lines @@
   EXPECT_EQ(1, table_view_.numberOfRows);
   // |table_view_| should be disabled since there is no option shown.
   EXPECT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   ExpectNoRowImage(0);
   ExpectRowTextIs(
       0, l10n_util::GetNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT));
   EXPECT_FALSE(IsRowPaired(0));
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_TRUE(status_.hidden);
+  EXPECT_TRUE(scanning_message_.hidden);
+  EXPECT_FALSE(word_connector_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   EXPECT_NSEQ(l10n_util::GetNSString(IDS_BLUETOOTH_DEVICE_CHOOSER_RE_SCAN),
               rescan_button_.title);
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 
   // Add options
   mock_chooser_controller_->OptionAdded(
       base::ASCIIToUTF16("a"),
       MockChooserController::kNoSignalStrengthLevelImage,
@@ skipping 15 matching lines @@
   EXPECT_TRUE(cancel_button_.enabled);
 
   mock_chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_OFF);
   EXPECT_FALSE(adapter_off_help_button_.hidden);
   EXPECT_NSEQ(l10n_util::GetNSString(
                   IDS_BLUETOOTH_DEVICE_CHOOSER_TURN_ON_BLUETOOTH_LINK_TEXT),
               adapter_off_help_button_.title);
   EXPECT_TRUE(table_view_.hidden);
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_TRUE(status_.hidden);
+  EXPECT_TRUE(scanning_message_.hidden);
+  EXPECT_TRUE(word_connector_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   // Since the adapter is turned off, the previously selected option
   // becomes invalid, the OK button is disabled.
   EXPECT_EQ(0u, mock_chooser_controller_->NumOptions());
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 
   mock_chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_ON);
   EXPECT_TRUE(adapter_off_help_button_.hidden);
@@ skipping 23 matching lines @@
       base::ASCIIToUTF16("c"), MockChooserController::kSignalStrengthLevel1Bar,
       MockChooserController::ConnectedPairedStatus::NONE);
   EXPECT_FALSE(table_view_.hidden);
   EXPECT_TRUE(table_view_.enabled);
   EXPECT_EQ(3, table_view_.numberOfRows);
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
   EXPECT_EQ(1, table_view_.selectedRow);
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_TRUE(status_.hidden);
+  EXPECT_TRUE(scanning_message_.hidden);
+  EXPECT_TRUE(word_connector_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   EXPECT_TRUE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 
   mock_chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::DISCOVERING);
   EXPECT_TRUE(table_view_.hidden);
   EXPECT_FALSE(spinner_.hidden);
-  EXPECT_FALSE(status_.hidden);
+  EXPECT_FALSE(scanning_message_.hidden);
+  EXPECT_TRUE(word_connector_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   // OK button is disabled since the chooser is refreshing options.
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 
   mock_chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::IDLE);
   EXPECT_FALSE(table_view_.hidden);
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   // |table_view_| should be disabled since there is no option shown.
   EXPECT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   ExpectNoRowImage(0);
   ExpectRowTextIs(
       0, l10n_util::GetNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT));
   EXPECT_FALSE(IsRowPaired(0));
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_TRUE(status_.hidden);
+  EXPECT_TRUE(scanning_message_.hidden);
+  EXPECT_FALSE(word_connector_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   EXPECT_NSEQ(l10n_util::GetNSString(IDS_BLUETOOTH_DEVICE_CHOOSER_RE_SCAN),
               rescan_button_.title);
   // OK button is disabled since the chooser refreshed options.
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest,
        DiscoveringAndOneOptionAddedAndSelectedAndIdle) {
@@ skipping 23 matching lines @@
   EXPECT_TRUE(table_view_.enabled);
   EXPECT_EQ(1, table_view_.numberOfRows);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   ExpectSignalStrengthLevelImageIs(
       0, MockChooserController::kSignalStrengthLevel2Bar,
       MockChooserController::kImageColorUnselected);
   ExpectRowTextIs(0, @"d");
   EXPECT_FALSE(IsRowPaired(0));
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_FALSE(status_.hidden);
+  EXPECT_FALSE(scanning_message_.hidden);
+  EXPECT_TRUE(word_connector_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   // OK button is disabled since no option is selected.
   EXPECT_FALSE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_EQ(0, table_view_.selectedRow);
   EXPECT_TRUE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 
   mock_chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::IDLE);
   EXPECT_FALSE(table_view_.hidden);
   EXPECT_TRUE(table_view_.enabled);
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(0, table_view_.selectedRow);
   ExpectRowTextIs(0, @"d");
   EXPECT_FALSE(IsRowPaired(0));
   EXPECT_TRUE(spinner_.hidden);
-  EXPECT_TRUE(status_.hidden);
+  EXPECT_TRUE(scanning_message_.hidden);
+  EXPECT_FALSE(word_connector_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   EXPECT_NSEQ(l10n_util::GetNSString(IDS_BLUETOOTH_DEVICE_CHOOSER_RE_SCAN),
               rescan_button_.title);
   EXPECT_TRUE(connect_button_.enabled);
   EXPECT_TRUE(cancel_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, PressAdapterOffHelpButton) {
   CreateChooserDialog();
 
@@ skipping 24 matching lines @@
       MockChooserController::ConnectedPairedStatus::NONE);
 
   // Select option 0 and press "Get help" button.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_CALL(*mock_chooser_controller_, Select(testing::_)).Times(0);
   EXPECT_CALL(*mock_chooser_controller_, Cancel()).Times(0);
   EXPECT_CALL(*mock_chooser_controller_, OpenHelpCenterUrl()).Times(1);
   [help_button_ performClick:chooser_dialog_controller_];
 }