Android ScreenCapture: add support to device rotation.

Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935
Committed: https://crrev.com/709ed4c443cb400660e0d88c888a0e9a4fbd5536
Cr-Commit-Position: refs/heads/master@{#430111}

[braveyao, 2016-11-03 00:38:21]

The CQ bit was checked by braveyao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 00:38:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 01:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:51:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[braveyao, 2016-11-03 16:36:52]

The CQ bit was checked by braveyao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 16:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 17:26:16]

Dry run: This issue passed the CQ dry run.

[braveyao, 2016-11-03 17:33:33]

Description was changed from

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during doing screen capture with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame asked
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored the codes a bit for a newly added unittest file.

BUG=487935
==========

to

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935
==========

[braveyao, 2016-11-03 17:34:58]

braveyao@chromium.org changed reviewers:
+ miu@chromium.org

[braveyao, 2016-11-03 17:34:58]

Hi miu@, please take a look at this when you get a chance.

[miu, 2016-11-04 22:45:12]

lgtm. I was wondering about certain behaviors (like, does the OS's capturer
automatically flip the image vertically in the case of 180° rotation, or do we
need to do that?). I'll just assume you've tested this thoroughly on an actual
device. ;)

https://codereview.chromium.org/2468383002/diff/1/media/capture/content/andro...
File
media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java
(right):

https://codereview.chromium.org/2468383002/diff/1/media/capture/content/andro...
media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java:332:
private void createImageReaderWithFormat(int format) {
This method is always being called with |mFormat| as the argument. So, can you
get rid of the argument and just use |mFormat| in the method's body?

[braveyao, 2016-11-04 23:10:47]

Thanks so much!
As to your question, yes, OS will flip the capture by itself when the device is
rotated 180° directly and we don't need to to anything since the frame
orientation doesn't change. For example I can test by rotate the device from
screen to back to achieve that, or with a phone(phone won't report Rotation_180
while tablet will) by rotating from Rotation_90 to Rotation_270.

https://codereview.chromium.org/2468383002/diff/1/media/capture/content/andro...
File
media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java
(right):

https://codereview.chromium.org/2468383002/diff/1/media/capture/content/andro...
media/capture/content/android/java/src/org/chromium/media/ScreenCapture.java:332:
private void createImageReaderWithFormat(int format) {
On 2016/11/04 22:45:11, miu wrote:
> This method is always being called with |mFormat| as the argument. So, can you
> get rid of the argument and just use |mFormat| in the method's body?

Done.

[braveyao, 2016-11-04 23:11:33]

The CQ bit was checked by braveyao@chromium.org

[braveyao, 2016-11-04 23:11:33]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2468383002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-04 23:12:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 01:12:29]

Description was changed from

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935
==========

to

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935
==========

[commit-bot: I haz the power, 2016-11-05 01:12:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 01:16:19]

Description was changed from

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935
==========

to

==========
Android ScreenCapture: add support to device rotation.

When device is rotated during screen capturing with MediaProjection API
on Android, the rotated screen will be captured and fit into the frame requested
with padding. So when we detect a device rotation, we need to re-create capture
with the new orientation and update the oracle.

Also refactored(mainly reordered some lines) the java file a bit for a newly
added unittest file.

BUG=487935

Committed: https://crrev.com/709ed4c443cb400660e0d88c888a0e9a4fbd5536
Cr-Commit-Position: refs/heads/master@{#430111}
==========

[commit-bot: I haz the power, 2016-11-05 01:16:20]

Patchset 2 (id:??) landed as
https://crrev.com/709ed4c443cb400660e0d88c888a0e9a4fbd5536
Cr-Commit-Position: refs/heads/master@{#430111}