Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2468363006: [Presentation API] cleanup: pass in MediaRoute instead of MediaRoute::Id to PresentationServiceDele… (Closed)

Created:
4 years, 1 month ago by zhaobin
Modified:
4 years, 1 month ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, media-router+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] cleanup: pass in MediaRoute instead of MediaRoute::Id to PresentationServiceDelegateImpl::OnPresentationSessionStarted() Seperate CL to resolve code review comments in https://codereview.chromium.org/2471883002/ BUG=662208 Committed: https://crrev.com/7419dd4ce85ab76c88a8a64e7805a07eb9dd7790 Cr-Commit-Position: refs/heads/master@{#433325}

Patch Set 1 #

Patch Set 2 : merge with upstream branch #

Patch Set 3 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 1 7 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
zhaobin
4 years, 1 month ago (2016-11-05 00:49:12 UTC) #2
imcheng
lgtm
4 years, 1 month ago (2016-11-07 21:43:33 UTC) #3
mark a. foltz
lgtm
4 years, 1 month ago (2016-11-09 20:22:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468363006/40001
4 years, 1 month ago (2016-11-18 22:56:05 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-18 23:09:43 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 23:11:57 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7419dd4ce85ab76c88a8a64e7805a07eb9dd7790
Cr-Commit-Position: refs/heads/master@{#433325}

Powered by Google App Engine
This is Rietveld 408576698