[MD settings] show blocked sites even when category is blocked

chrome/browser/resources/settings/site_settings/add_site_dialog.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'add-site-dialog' provides a dialog to add exceptions for a given Content
  * Settings category.
  */
 Polymer({
   is: 'add-site-dialog',
 
   behaviors: [SiteSettingsBehavior, WebUIListenerBehavior],
 
   properties: {
+    /* What kind of setting, e.g. Location, Camera, Cookies, and so on. */
+    category: String,
+
+    /* Whether this is about an Allow, Block, SessionOnly, or other. */
+    contentSetting: String,

[dpapad, 2016/11/08 00:12:32]

As discussed, could this be typed as an enum instead of string? If that is too
much of a change, seperate CL is fine.

[dschuyler, 2016/11/08 00:40:50]

Done.

+
     /**
      * The site to add an exception for.
      * @private
      */
     site_: String,
+  },
 
-    /**
-     * Whether this is an allow exception this dialog is adding.
-     */
-     allowException: Boolean,
+  /** @override */
+  attached: function() {
+    assert(this.category);
+    assert(this.contentSetting);
   },
 
   /**
    * Opens the dialog.
    * @param {string} type Whether this was launched from an Allow list or a
    *     Block list.
    */
   open: function(type) {
     this.addWebUIListener('onIncognitoStatusChanged',
         this.onIncognitoStatusChanged_.bind(this));
-    this.allowException = type == settings.PermissionValues.ALLOW;
     this.browserProxy.updateIncognitoStatus();
     this.$.dialog.showModal();
   },
 
   /**
    * Validates that the pattern entered is valid.
    * @private
    */
   validate_: function() {
     this.browserProxy.isPatternValid(this.site_).then(function(isValid) {
@@ skipping 22 matching lines @@
   /**
    * The tap handler for the Add [Site] button (adds the pattern and closes
    * the dialog).
    * @private
    */
   onSubmit_: function() {
     if (this.$.add.disabled)
       return;  // Can happen when Enter is pressed.
     var pattern = this.addPatternWildcard(this.site_);
     this.browserProxy.setCategoryPermissionForOrigin(
-        pattern, pattern, this.category, this.allowException ?
-            settings.PermissionValues.ALLOW : settings.PermissionValues.BLOCK,
+        pattern, pattern, this.category, this.contentSetting,
         this.$.incognito.checked);
     this.$.dialog.close();
   },
 });