Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2468363002: Add a config for optional UBSan trybot. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add a config for optional UBSan trybot. The plan is to eventually make it a part of CQ, but the first step is to set it up as optional, measure performance and other things, and then go through a technical review for getting the trybot into the CQ. BUG=612594 Committed: https://chromium.googlesource.com/chromium/tools/build/+/3c0d76d7ccbc0957ab0edf78333b77661b8ffe89

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +7 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 1 chunk +4 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_ubsan_rel_ng.json View 7 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
krasin1
4 years, 1 month ago (2016-11-02 23:19:23 UTC) #2
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-03 00:15:56 UTC) #7
krasin1
On 2016/11/03 00:15:56, Dirk Pranke wrote: > lgtm Thank you, Dirk!
4 years, 1 month ago (2016-11-03 00:17:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468363002/1
4 years, 1 month ago (2016-11-03 00:17:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/3c0d76d7ccbc0957ab0edf78333b77661b8ffe89
4 years, 1 month ago (2016-11-03 00:27:23 UTC) #12
Michael Achenbach
See https://codereview.chromium.org/2477673002/
4 years, 1 month ago (2016-11-03 12:52:48 UTC) #14
krasin1
On 2016/11/03 12:52:48, machenbach (slow) wrote: > See https://codereview.chromium.org/2477673002/ Thank you for fixing it, and ...
4 years, 1 month ago (2016-11-03 17:25:19 UTC) #15
krasin1
4 years, 1 month ago (2016-11-04 03:36:21 UTC) #16
Message was sent while issue was closed.
On 2016/11/03 17:25:19, krasin1 wrote:
> On 2016/11/03 12:52:48, machenbach (slow) wrote:
> > See https://codereview.chromium.org/2477673002/
> 
> Thank you for fixing it, and sorry for the breakage. :(

I have been thinking for the whole day trying to reproduce the sequence of
actions which led to the mistake (to avoid it in the future), and it appears to
be the following:

1. I have added the new ubsan trybot to the list of trybots served by CQ trybots
pool near the asan one.
2. I realized it's the wrong place, as I was looking for the slaves serving the
optional bots
3. I have cut the wrong line (asan instead of ubsan) and pasted into the correct
place for the ubsan bot.

That created this diff and asan bot got significantly fewer slaves. And then I
didn't spot it during a self-review.

Apologies again, I will try to better.

Powered by Google App Engine
This is Rietveld 408576698