Filter out datalist values for textarea field from renderer side.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 622 matching lines @@
     // If we didn't find the cached form, at least let autocomplete have a shot
     // at providing suggestions.
     WebFormControlElementToFormField(element, EXTRACT_VALUE, &field);
   }
   if (datalist_only)
     field.should_autocomplete = false;
 
   gfx::RectF bounding_box_scaled =
       GetScaledBoundingBox(web_view_->pageScaleFactor(), &element_);
 
+  std::vector<base::string16> data_list_values;
+  std::vector<base::string16> data_list_labels;
   const WebInputElement* input_element = toWebInputElement(&element);
   if (input_element) {
     // Find the datalist values and send them to the browser process.
-    std::vector<base::string16> data_list_values;
-    std::vector<base::string16> data_list_labels;
     GetDataListSuggestions(*input_element,
                            datalist_only,
                            &data_list_values,
                            &data_list_labels);
     TrimStringVectorForIPC(&data_list_values);
     TrimStringVectorForIPC(&data_list_labels);
-
-    Send(new AutofillHostMsg_SetDataList(routing_id(),
-                                         data_list_values,
-                                         data_list_labels));
   }
 
   is_popup_possibly_visible_ = true;
+  Send(new AutofillHostMsg_SetDataList(routing_id(),
+                                       data_list_values,
+                                       data_list_labels));

[Ilya Sherman, 2014/04/29 20:29:30]

Aha!  This makes perfect sense -- we were showing stale values for the data
list.

It seems like it might make sense to just include the data list values and
labels as part of the AutofillHostMsg_QueryFormFieldAutofill message.  WDYT?

[ziran.sun, 2014/04/30 10:05:22]

It might make sense to send one message rather than two in this case. However, I
feel that this has restricted setDatalist call within queryFormFieldAutofill().
I'm thinking cases that we only want to update datalist values. The other things
is - inserting data_list_values and data_list_labels to
AutofillHostMsg_QueryFormFieldAutofill means that we also need to interact
IPC_messages to handle 7 arguments (at this moment it handles maximum 5
arguments).

Do let me know if I missed any key points though. Thanks!

+
   Send(new AutofillHostMsg_QueryFormFieldAutofill(routing_id(),
                                                   autofill_query_id_,
                                                   form,
                                                   field,
                                                   bounding_box_scaled,
                                                   display_warning_if_disabled));
 }
 
 void AutofillAgent::FillFieldWithValue(const base::string16& value,
                                        WebInputElement* node) {
@@ skipping 29 matching lines @@
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet.
     if (frame && !frame->parent()) {
       password_autofill_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill