Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2468303005: Mark TranslateTransformOperation final (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
Reviewers:
Stephen Chennney, pdr.
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark TranslateTransformOperation final Nothing derives from it. This also allows devirtualization of the call to apply() for the 'translate' (independent) property. BUG=369942 Committed: https://crrev.com/b63b367a8bef64e8c897677f847af1af1faa7fc8 Cr-Commit-Position: refs/heads/master@{#429840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
fs
4 years, 1 month ago (2016-11-03 14:23:40 UTC) #6
pdr.
♫ It's the final countdown. ♫ ♫ The final count.down. ♫ - Europe LGTM
4 years, 1 month ago (2016-11-03 18:37:06 UTC) #7
fs
On 2016/11/03 at 18:37:06, pdr wrote: > ♫ It's the final countdown. ♫ > ♫ ...
4 years, 1 month ago (2016-11-04 09:22:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468303005/1
4 years, 1 month ago (2016-11-04 09:23:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 09:27:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 09:29:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b63b367a8bef64e8c897677f847af1af1faa7fc8
Cr-Commit-Position: refs/heads/master@{#429840}

Powered by Google App Engine
This is Rietveld 408576698