third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp - Issue 2468303002: [RemotePlayback] Stop remote playback when disableRemotePlayback is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

Issue 2468303002: [RemotePlayback] Stop remote playback when disableRemotePlayback is set (Closed)

Patch Set: Rebase, addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

diff --git a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

index b37abe9022dd79c864b49f6975abb6367b64bdc5..88530f205fd29c710f6d891543122b4dc6d3f546 100644

--- a/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

+++ b/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp

@@ -269,7 +269,8 @@ void RemotePlayback::remotePlaybackDisabled() {

m_availabilityCallbacks.clear();

- // TODO(avayvod): stop remote playback too. https://crbug.com/657566.

+ if (m_state != WebRemotePlaybackState::Disconnected)

+ m_mediaElement->requestRemotePlaybackStop();

}

void RemotePlayback::setV8ReferencesForCallbacks(

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayer.h » ('j') | no next file with comments »