Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2468283003: Revert of [sensors] Ambient light sensor implementation for ChromeOS and Linux. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
CC:
darktears, chromium-reviews, riju_
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sensors] Ambient light sensor implementation for ChromeOS and Linux. (patchset #26 id:1050001 of https://codereview.chromium.org/2370343002/ ) Reason for revert: Causing a failure on Linux bot: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/28030 Original issue's description: > [sensors] Ambient light sensor implementation for ChromeOS and Linux. > > The patch introduces sensors implementation for > ChromeOS/Linux platforms using ambient light sensor. Both > platforms share the same code and require polling threads to > be used. > > SensorDataIio structure is used to initialize a generic > SensorReader, which is created only when sensor read files > are found, and to create a concrete sensor, which takes > an ownership of the SensorReader. > > A SensorReader must always be created on a polling thread, > which is further used by a sensor to poll data. Each new > sensor will have its own thread in order to avoid blocking of > each other. > > As a temp solution to manage polling threads, which are not > passed to new sensors, a manager thread is used. It kills a > polling thread if a sensor cannot be created. In the future, > the manager thread will evolve to a manager class that will > manage finding new sensors attached to a system and notify a > provider about that. The provider will have its own cache in > order to avoid trying to find sensors each time after it > fails to find a requested sensor. Once the manager notifies > the provider about a new sensor, the provider updates its > cache and starts to process requests for that type of sensor. > > Intent to Implement: > https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TkfdVqYAYiE/xLGN2b1-AAAJ > > BUG=606766 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/de2d07084492be68633a47bae161cf9014ac88e2 > Cr-Commit-Position: refs/heads/master@{#429584} TBR=reillyg@chromium.org,alexander.shalamov@intel.com,alexis.menard@intel.com,alexmos@chromium.org,mikhail.pozdnyakov@intel.com,rockot@chromium.org,timvolodine@chromium.org,maksim.sisov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=606766 Committed: https://crrev.com/ae21a578c51e7d8a6a228dbd27594dea0416cf8b Cr-Commit-Position: refs/heads/master@{#429604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -886 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M device/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/generic_sensor/BUILD.gn View 2 chunks +1 line, -11 lines 0 comments Download
D device/generic_sensor/linux/platform_sensor_utils_linux.h View 1 chunk +0 lines, -43 lines 0 comments Download
D device/generic_sensor/linux/platform_sensor_utils_linux.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D device/generic_sensor/linux/sensor_data_linux.h View 1 chunk +0 lines, -38 lines 0 comments Download
D device/generic_sensor/linux/sensor_data_linux.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D device/generic_sensor/linux/sensor_reader_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D device/generic_sensor/platform_sensor_linux.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/generic_sensor/platform_sensor_linux.cc View 1 chunk +0 lines, -114 lines 0 comments Download
M device/generic_sensor/platform_sensor_provider.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M device/generic_sensor/platform_sensor_provider_base.h View 1 chunk +0 lines, -5 lines 0 comments Download
D device/generic_sensor/platform_sensor_provider_linux.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/generic_sensor/platform_sensor_provider_linux.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M device/generic_sensor/sensor_provider_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mathieu
Created Revert of [sensors] Ambient light sensor implementation for ChromeOS and Linux.
4 years, 1 month ago (2016-11-03 16:00:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468283003/1
4 years, 1 month ago (2016-11-03 16:01:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 16:03:19 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 16:11:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae21a578c51e7d8a6a228dbd27594dea0416cf8b
Cr-Commit-Position: refs/heads/master@{#429604}

Powered by Google App Engine
This is Rietveld 408576698