Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2468263003: Fix a null-deref in safe_browsing::dmg::UDIFParser::ParseBlkx. (Closed)

Created:
4 years, 1 month ago by Robert Sesek
Modified:
4 years, 1 month ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a null-deref in safe_browsing::dmg::UDIFParser::ParseBlkx. The typechecking CFCast<T> returns null if the source type does not match the destination type, but ParseBlkx was not checking the result for null. BUG=654926 R=nparker@chromium.org Committed: https://crrev.com/39ad5ff8e03689a22f387699b595952a7dc93fda Cr-Commit-Position: refs/heads/master@{#429918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/utility/safe_browsing/mac/udif.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Robert Sesek
4 years, 1 month ago (2016-11-02 19:48:18 UTC) #3
Robert Sesek
Friendly ping
4 years, 1 month ago (2016-11-04 14:08:32 UTC) #6
Nathan Parker
lgtm
4 years, 1 month ago (2016-11-04 16:16:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468263003/1
4 years, 1 month ago (2016-11-04 16:17:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 16:51:10 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:16:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39ad5ff8e03689a22f387699b595952a7dc93fda
Cr-Commit-Position: refs/heads/master@{#429918}

Powered by Google App Engine
This is Rietveld 408576698