Handle exception when user call canvas.transferControlToOffscreen() twice

Handle exception when user call canvas.transferControlToOffscreen() twice

BUG=659260
Committed: https://crrev.com/6a5ce93ef72769d259a04209a85b574323c1962f
Cr-Commit-Position: refs/heads/master@{#429644}

[xlai (Olivia), 2016-11-02 16:51:39]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-11-02 20:00:11]

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (left):

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:1353:
DCHECK(!m_surfaceLayerBridge);
I think this DCHECK should stay.  It was probably firing before you made the fix
in HTMLCanvasElementModule.cpp, but now it should be Okay.

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
(right):

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp:40: if
(!!canvas.surfaceLayerBridge()) {
No need for !!

[xlai (Olivia), 2016-11-02 20:07:50]

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (left):

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:1353:
DCHECK(!m_surfaceLayerBridge);
On 2016/11/02 20:00:11, Justin Novosad wrote:
> I think this DCHECK should stay.  It was probably firing before you made the
fix
> in HTMLCanvasElementModule.cpp, but now it should be Okay.

Done.

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp
(right):

https://codereview.chromium.org/2468263002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/canvas/HTMLCanvasElementModule.cpp:40: if
(!!canvas.surfaceLayerBridge()) {
On 2016/11/02 20:00:11, Justin Novosad wrote:
> No need for !!

Done.

[Justin Novosad, 2016-11-03 14:09:26]

lgtm

[xlai (Olivia), 2016-11-03 14:42:06]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:57:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 18:14:28]

Description was changed from

==========
Handle exception when user call canvas.transferControlToOffscreen() twice

BUG=659260
==========

to

==========
Handle exception when user call canvas.transferControlToOffscreen() twice

BUG=659260

Committed: https://crrev.com/6a5ce93ef72769d259a04209a85b574323c1962f
Cr-Commit-Position: refs/heads/master@{#429644}
==========

[commit-bot: I haz the power, 2016-11-03 18:14:29]

Patchset 2 (id:??) landed as
https://crrev.com/6a5ce93ef72769d259a04209a85b574323c1962f
Cr-Commit-Position: refs/heads/master@{#429644}