Issue 2468223003: Include LineInfo into AnalysisResult to allow reporting errors with lines/columns.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2468223003: Include LineInfo into AnalysisResult to allow reporting errors with lines/columns. (Closed)

Created:
4 years, 1 month ago by scheglov

Modified:
4 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	pkg/analysis_server/lib/src/computer/new_notifications.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/analysis/file_state.dart	View	3 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Paul Berry

lgtm, though I'm a little confused about why one change affects both the new analyzer ...

4 years, 1 month ago (2016-11-03 12:20:52 UTC) #2

scheglov

4 years, 1 month ago (2016-11-03 15:39:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f55a9760fc0ed6ce7a153fa3afc2e1a63216d21d (presubmit successful).