Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2468193002: Revert of Improve how the column balancer handles top margins on floats. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index b83e27e00f66abd9fdddf4c0e3b385d4bb351a60..5aad7f755841285c46b4aeb9ace8980f0c7075c0 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -706,8 +706,8 @@
layer()->updateTransformationMatrix();
}
-LayoutUnit LayoutBox::logicalHeightWithVisibleOverflow() const {
- if (!m_overflow || hasOverflowClip())
+LayoutUnit LayoutBox::logicalHeightIncludingOverflow() const {
+ if (!m_overflow)
return logicalHeight();
LayoutRect overflow = layoutOverflowRect();
if (style()->isHorizontalWritingMode())
@@ -4712,7 +4712,7 @@
return;
LayoutUnit logicalTop = child.logicalTop();
- LayoutUnit logicalHeight = child.logicalHeightWithVisibleOverflow();
+ LayoutUnit logicalHeight = child.logicalHeightIncludingOverflow();
LayoutUnit spaceLeft =
pageRemainingLogicalHeightForOffset(logicalTop, AssociateWithLatterPage);
if (spaceLeft < logicalHeight)
@@ -4729,7 +4729,7 @@
// to do this if there's a chance that we need to recalculate pagination
// struts inside.
if (LayoutUnit pageLogicalHeight = pageLogicalHeightForOffset(logicalTop)) {
- LayoutUnit logicalHeight = child.logicalHeightWithVisibleOverflow();
+ LayoutUnit logicalHeight = child.logicalHeightIncludingOverflow();
LayoutUnit remainingSpace = pageRemainingLogicalHeightForOffset(
logicalTop, AssociateWithLatterPage);
if (child.offsetToNextPage()) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698