Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: gpu/command_buffer/service/vertex_attrib_manager.cc

Issue 2468123002: Change BufferManager::RequestBufferAccess signatures to avoid sprintfs. (Closed)
Patch Set: Simplified one RequestBufferAccess variant causing nested va_list usage. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/vertex_attrib_manager.cc
diff --git a/gpu/command_buffer/service/vertex_attrib_manager.cc b/gpu/command_buffer/service/vertex_attrib_manager.cc
index abaecea39018b6c13321f7ab7fa10c9becb41b36..a48c678d28a8e3f4a3293644fe9fa32b71b16a3f 100644
--- a/gpu/command_buffer/service/vertex_attrib_manager.cc
+++ b/gpu/command_buffer/service/vertex_attrib_manager.cc
@@ -202,10 +202,10 @@ bool VertexAttribManager::ValidateBindings(
it != enabled_vertex_attribs_.end(); ++it) {
VertexAttrib* attrib = *it;
Buffer* buffer = attrib->buffer();
- std::string msg_tag = base::StringPrintf(
- "attached to enabled attrib %u", attrib->index());
if (!buffer_manager->RequestBufferAccess(
- error_state, buffer, function_name, msg_tag.c_str())) {
+ error_state, buffer, function_name,
+ "attached to enabled attrib %u",
+ attrib->index())) {
return false;
}
const Program::VertexAttrib* attrib_info =
« gpu/command_buffer/service/buffer_manager.cc ('K') | « gpu/command_buffer/service/buffer_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698