Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2468113003: Constraint space for current child should be adjusted to offset. (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Constraint space for current child should be adjusted to offset. As we now have space_for_current_child_ it should be used to search layout opportunities for floats. Also space_for_current_child_'s offset should be adjusted according to the available space. List of changes: - Change FindLayoutOpportunityForFragment to use space_for_current_child_. - Rename CreateConstraintSpaceForChild -> CreateConstraintSpaceForCurrentChild and make it a private class's method. - Adjust space_for_current_child_'s offset to the available space. - Change NGBlockLayoutAlgorithmTest::PositionFloatFragments to include a regular block between floats. BUG=635619 Committed: https://crrev.com/07703ad5e0afd141d4a6da847ffec5c372b7b566 Cr-Commit-Position: refs/heads/master@{#429622}

Patch Set 1 #

Patch Set 2 : add 2 TODOs in CreateConstraintSpaceForCurrentChild, remove Mutable* API #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -51 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 7 chunks +30 lines, -28 lines 2 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 2 chunks +33 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-02 01:35:35 UTC) #2
Gleb Lanbin
updated the code based on our morning offline discussion and removed mutable API.
4 years, 1 month ago (2016-11-02 18:48:59 UTC) #4
cbiesinger
lgtm
4 years, 1 month ago (2016-11-02 19:14:49 UTC) #5
ikilpatrick
lgtm https://codereview.chromium.org/2468113003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2468113003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode332 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:332: space_for_current_child_, fragment, margins); I'm not sure that space_for_current_child_ ...
4 years, 1 month ago (2016-11-03 16:41:03 UTC) #10
Gleb Lanbin
https://codereview.chromium.org/2468113003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2468113003/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc#newcode332 third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:332: space_for_current_child_, fragment, margins); On 2016/11/03 16:41:02, ikilpatrick wrote: > ...
4 years, 1 month ago (2016-11-03 16:51:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468113003/20001
4 years, 1 month ago (2016-11-03 16:51:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 16:57:29 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:13:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07703ad5e0afd141d4a6da847ffec5c372b7b566
Cr-Commit-Position: refs/heads/master@{#429622}

Powered by Google App Engine
This is Rietveld 408576698