Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: runtime/lib/isolate.cc

Issue 2468093007: clang-format runtime/lib (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/invocation_mirror.h ('k') | runtime/lib/libgen_in.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/isolate.cc
diff --git a/runtime/lib/isolate.cc b/runtime/lib/isolate.cc
index 54a55ee00b8cefb077a57bb3ee74b3ce0ddbd777..d88fbc8c5d6f8c10eb034326e417ce54501e0270 100644
--- a/runtime/lib/isolate.cc
+++ b/runtime/lib/isolate.cc
@@ -25,7 +25,9 @@
namespace dart {
-DEFINE_FLAG(bool, i_like_slow_isolate_spawn, false,
+DEFINE_FLAG(bool,
+ i_like_slow_isolate_spawn,
+ false,
"Block the parent thread when loading spawned isolates.");
static uint8_t* allocator(uint8_t* ptr, intptr_t old_size, intptr_t new_size) {
@@ -60,8 +62,7 @@ DEFINE_NATIVE_ENTRY(CapabilityImpl_get_hashcode, 1) {
DEFINE_NATIVE_ENTRY(RawReceivePortImpl_factory, 1) {
ASSERT(TypeArguments::CheckedHandle(arguments->NativeArgAt(0)).IsNull());
- Dart_Port port_id =
- PortMap::CreatePort(isolate->message_handler());
+ Dart_Port port_id = PortMap::CreatePort(isolate->message_handler());
return ReceivePort::New(port_id, false /* not control port */);
}
@@ -111,16 +112,16 @@ DEFINE_NATIVE_ENTRY(SendPortImpl_sendInternal_, 2) {
const bool can_send_any_object = isolate->origin_id() == port.origin_id();
if (ApiObjectConverter::CanConvert(obj.raw())) {
- PortMap::PostMessage(new Message(
- destination_port_id, obj.raw(), Message::kNormalPriority));
+ PortMap::PostMessage(
+ new Message(destination_port_id, obj.raw(), Message::kNormalPriority));
} else {
uint8_t* data = NULL;
MessageWriter writer(&data, &allocator, can_send_any_object);
writer.WriteMessage(obj);
// TODO(turnidge): Throw an exception when the return value is false?
- PortMap::PostMessage(new Message(destination_port_id,
- data, writer.BytesWritten(),
+ PortMap::PostMessage(new Message(destination_port_id, data,
+ writer.BytesWritten(),
Message::kNormalPriority));
}
return Object::null();
@@ -154,14 +155,9 @@ class SpawnIsolateTask : public ThreadPool::Task {
// Make a copy of the state's isolate flags and hand it to the callback.
Dart_IsolateFlags api_flags = *(state_->isolate_flags());
- Isolate* isolate = reinterpret_cast<Isolate*>(
- (callback)(state_->script_url(),
- state_->function_name(),
- state_->package_root(),
- state_->package_config(),
- &api_flags,
- state_->init_data(),
- &error));
+ Isolate* isolate = reinterpret_cast<Isolate*>((callback)(
+ state_->script_url(), state_->function_name(), state_->package_root(),
+ state_->package_config(), &api_flags, state_->init_data(), &error));
state_->DecrementSpawnCount();
if (isolate == NULL) {
ReportError(error);
@@ -245,21 +241,12 @@ DEFINE_NATIVE_ENTRY(Isolate_spawnFunction, 10) {
Dart_Port on_exit_port = onExit.IsNull() ? ILLEGAL_PORT : onExit.Id();
Dart_Port on_error_port = onError.IsNull() ? ILLEGAL_PORT : onError.Id();
- IsolateSpawnState* state =
- new IsolateSpawnState(port.Id(),
- isolate->origin_id(),
- isolate->init_callback_data(),
- String2UTF8(script_uri),
- func,
- message,
- isolate->spawn_count_monitor(),
- isolate->spawn_count(),
- utf8_package_root,
- utf8_package_config,
- paused.value(),
- fatal_errors,
- on_exit_port,
- on_error_port);
+ IsolateSpawnState* state = new IsolateSpawnState(
+ port.Id(), isolate->origin_id(), isolate->init_callback_data(),
+ String2UTF8(script_uri), func, message,
+ isolate->spawn_count_monitor(), isolate->spawn_count(),
+ utf8_package_root, utf8_package_config, paused.value(), fatal_errors,
+ on_exit_port, on_error_port);
ThreadPool::Task* spawn_task = new SpawnIsolateTask(state);
isolate->IncrementSpawnCount();
@@ -300,9 +287,9 @@ static const char* CanonicalizeUri(Thread* thread,
if (handler != NULL) {
TransitionVMToNative transition(thread);
Dart_EnterScope();
- Dart_Handle handle = handler(Dart_kCanonicalizeUrl,
- Api::NewHandle(thread, library.raw()),
- Api::NewHandle(thread, uri.raw()));
+ Dart_Handle handle =
+ handler(Dart_kCanonicalizeUrl, Api::NewHandle(thread, library.raw()),
+ Api::NewHandle(thread, uri.raw()));
const Object& obj = Object::Handle(Api::UnwrapHandle(handle));
if (obj.IsString()) {
result = String2UTF8(String::Cast(obj));
@@ -312,9 +299,10 @@ static const char* CanonicalizeUri(Thread* thread,
*error = zone->PrintToString("Unable to canonicalize uri '%s': %s",
uri.ToCString(), error_obj.ToErrorCString());
} else {
- *error = zone->PrintToString("Unable to canonicalize uri '%s': "
- "library tag handler returned wrong type",
- uri.ToCString());
+ *error = zone->PrintToString(
+ "Unable to canonicalize uri '%s': "
+ "library tag handler returned wrong type",
+ uri.ToCString());
}
Dart_ExitScope();
} else {
@@ -348,7 +336,7 @@ DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 12) {
if (Snapshot::IncludesCode(Dart::snapshot_kind())) {
const Array& args = Array::Handle(Array::New(1));
args.SetAt(0, String::Handle(String::New(
- "Isolate.spawnUri not supported under precompilation")));
+ "Isolate.spawnUri not supported under precompilation")));
Exceptions::ThrowByType(Exceptions::kUnsupported, args);
UNREACHABLE();
}
@@ -372,21 +360,11 @@ DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 12) {
Dart_Port on_exit_port = onExit.IsNull() ? ILLEGAL_PORT : onExit.Id();
Dart_Port on_error_port = onError.IsNull() ? ILLEGAL_PORT : onError.Id();
- IsolateSpawnState* state =
- new IsolateSpawnState(
- port.Id(),
- isolate->init_callback_data(),
- canonical_uri,
- utf8_package_root,
- utf8_package_config,
- args,
- message,
- isolate->spawn_count_monitor(),
- isolate->spawn_count(),
- paused.value(),
- fatal_errors,
- on_exit_port,
- on_error_port);
+ IsolateSpawnState* state = new IsolateSpawnState(
+ port.Id(), isolate->init_callback_data(), canonical_uri,
+ utf8_package_root, utf8_package_config, args, message,
+ isolate->spawn_count_monitor(), isolate->spawn_count(), paused.value(),
+ fatal_errors, on_exit_port, on_error_port);
// If we were passed a value then override the default flags state for
// checked mode.
@@ -423,17 +401,17 @@ DEFINE_NATIVE_ENTRY(Isolate_spawnUri, 12) {
DEFINE_NATIVE_ENTRY(Isolate_getPortAndCapabilitiesOfCurrentIsolate, 0) {
const Array& result = Array::Handle(Array::New(3));
result.SetAt(0, SendPort::Handle(SendPort::New(isolate->main_port())));
- result.SetAt(1, Capability::Handle(
- Capability::New(isolate->pause_capability())));
- result.SetAt(2, Capability::Handle(
- Capability::New(isolate->terminate_capability())));
+ result.SetAt(
+ 1, Capability::Handle(Capability::New(isolate->pause_capability())));
+ result.SetAt(
+ 2, Capability::Handle(Capability::New(isolate->terminate_capability())));
return result.raw();
}
DEFINE_NATIVE_ENTRY(Isolate_getCurrentRootUriStr, 0) {
- const Library& root_lib = Library::Handle(zone,
- isolate->object_store()->root_library());
+ const Library& root_lib =
+ Library::Handle(zone, isolate->object_store()->root_library());
return root_lib.url();
}
@@ -449,8 +427,7 @@ DEFINE_NATIVE_ENTRY(Isolate_sendOOB, 2) {
MessageWriter writer(&data, &allocator, false);
writer.WriteMessage(msg);
- PortMap::PostMessage(new Message(port.Id(),
- data, writer.BytesWritten(),
+ PortMap::PostMessage(new Message(port.Id(), data, writer.BytesWritten(),
Message::kOOBPriority));
return Object::null();
}
« no previous file with comments | « runtime/lib/invocation_mirror.h ('k') | runtime/lib/libgen_in.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698