Updated error message in PerformanceObserver.observe

Updated error message in PerformanceObserver.observe

BUG=662210
Committed: https://crrev.com/920e411ac7f876467faa8454256578d103e0304b
Cr-Commit-Position: refs/heads/master@{#431165}

[sunjian, 2016-11-04 19:18:25]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunjian, 2016-11-04 20:41:21]

sunjian@chromium.org changed reviewers:
+ panicker@google.com

[panicker, 2016-11-04 21:19:28]

panicker@chromium.org changed reviewers:
+ panicker@chromium.org, yoav@yoav.ws

[panicker, 2016-11-04 21:19:28]

LGTM.
+Yoav for Owners

[Yoav Weiss, 2016-11-04 21:49:16]

LGTM % suggestion for a slightly clearer error message

https://codereview.chromium.org/2468063006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceObserver.cpp (right):

https://codereview.chromium.org/2468063006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceObserver.cpp:52: "A Performance
Observer MUST have a valid entryTypes attribute.");
Just to clarify, if one of the entries is valid, this doesn't throw, right?
If so, maybe the error thrown should reflect that? "A Performance Observer MUST
have at least one valid entryType in its entryTypes attribute."?

[commit-bot: I haz the power, 2016-11-04 23:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 23:31:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunjian, 2016-11-09 23:27:58]

https://codereview.chromium.org/2468063006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/timing/PerformanceObserver.cpp (right):

https://codereview.chromium.org/2468063006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/timing/PerformanceObserver.cpp:52: "A Performance
Observer MUST have a valid entryTypes attribute.");
On 2016/11/04 21:49:16, Yoav Weiss wrote:
> Just to clarify, if one of the entries is valid, this doesn't throw, right?
> If so, maybe the error thrown should reflect that? "A Performance Observer
MUST
> have at least one valid entryType in its entryTypes attribute."?

Done.

[sunjian, 2016-11-09 23:28:08]

The CQ bit was checked by sunjian@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 23:28:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 01:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 01:04:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[panicker, 2016-11-10 01:29:55]

The CQ bit was checked by panicker@chromium.org

[panicker, 2016-11-10 01:29:56]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2468063006/#ps20001
(title: "resolved comments")

[commit-bot: I haz the power, 2016-11-10 01:30:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 03:23:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 03:27:19]

Description was changed from

==========
Updated error message in PerformanceObserver.observe

BUG=662210
==========

to

==========
Updated error message in PerformanceObserver.observe

BUG=662210

Committed: https://crrev.com/920e411ac7f876467faa8454256578d103e0304b
Cr-Commit-Position: refs/heads/master@{#431165}
==========

[commit-bot: I haz the power, 2016-11-10 03:27:21]

Patchset 2 (id:??) landed as
https://crrev.com/920e411ac7f876467faa8454256578d103e0304b
Cr-Commit-Position: refs/heads/master@{#431165}