Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2468043002: Removed OnShowingPastePopup (Closed)

Created:
4 years, 1 month ago by amaralp
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed OnShowingPastePopup OnShowingPastePopup was a hack that is causing test flakiness. This CL removes it. BUG=592428 Committed: https://crrev.com/abb5f9cb42bdfe9b13c71d02496131d24e96f6f3 Cr-Commit-Position: refs/heads/master@{#429189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
amaralp
PTAL
4 years, 1 month ago (2016-11-01 22:44:00 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-01 23:43:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468043002/1
4 years, 1 month ago (2016-11-01 23:55:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/294577)
4 years, 1 month ago (2016-11-02 00:07:44 UTC) #11
amaralp
Added boliu@ for content/browser OWNERS
4 years, 1 month ago (2016-11-02 00:53:58 UTC) #13
boliu
rs lgtm
4 years, 1 month ago (2016-11-02 02:08:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2468043002/1
4 years, 1 month ago (2016-11-02 02:39:10 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 02:43:18 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 02:46:51 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abb5f9cb42bdfe9b13c71d02496131d24e96f6f3
Cr-Commit-Position: refs/heads/master@{#429189}

Powered by Google App Engine
This is Rietveld 408576698