Merge delegates into IFWL_* classes.

Merge delegates into IFWL_* classes.

This Cl removes ownership of the delgates from IFWL_Widget and puts it in the
hand of the creating classes. In doing so, merge the delegates back into the
IFWL_* classes to simplify logic.

Committed: https://pdfium.googlesource.com/pdfium/+/3b3ce1a242f8445848d3f23d6c35ba01d7c645f4

[dsinclair, 2016-11-02 17:50:33]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 17:50:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-02 17:51:04]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-02 17:51:05]

PTAL.

tsepez@ does this better match what we discussed yesterday? I think this is a
lot clearer what's going on.

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h#...
xfa/fwl/core/ifwl_widget.h:116: IFWL_WidgetDelegate* GetDelegate() {
This isn't const because I return |this|. I can make this const by doing a
const_cast but thought this was clearer.

[commit-bot: I haz the power, 2016-11-02 18:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 18:07:36]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-02 21:03:29]

Yes, this is OK; a class can be its own delegate to provide defaults behaviour.

LGTM

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h#...
xfa/fwl/core/ifwl_widget.h:116: IFWL_WidgetDelegate* GetDelegate() {
On 2016/11/02 17:51:05, dsinclair wrote:
> This isn't const because I return |this|. I can make this const by doing a
> const_cast but thought this was clearer.

Actually, you may want to have an overload: e.g.
IFWL_WidgetDelegate* GetDelegate();
const IFWL_WidgetDelegate* GetDelegate() const;

[dsinclair, 2016-11-02 21:11:14]

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h
File xfa/fwl/core/ifwl_widget.h (right):

https://codereview.chromium.org/2467993003/diff/1/xfa/fwl/core/ifwl_widget.h#...
xfa/fwl/core/ifwl_widget.h:116: IFWL_WidgetDelegate* GetDelegate() {
On 2016/11/02 21:03:29, Tom Sepez wrote:
> On 2016/11/02 17:51:05, dsinclair wrote:
> > This isn't const because I return |this|. I can make this const by doing a
> > const_cast but thought this was clearer.
> 
> Actually, you may want to have an overload: e.g.
> IFWL_WidgetDelegate* GetDelegate();
> const IFWL_WidgetDelegate* GetDelegate() const;

Done.

[dsinclair, 2016-11-02 21:11:25]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-02 21:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2467993003/#ps20001
(title: "Add const version")

[commit-bot: I haz the power, 2016-11-02 21:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:51:27]

Description was changed from

==========
Merge delegates into IFWL_* classes.

This Cl removes ownership of the delgates from IFWL_Widget and puts it in the
hand of the creating classes. In doing so, merge the delegates back into the
IFWL_* classes to simplify logic.
==========

to

==========
Merge delegates into IFWL_* classes.

This Cl removes ownership of the delgates from IFWL_Widget and puts it in the
hand of the creating classes. In doing so, merge the delegates back into the
IFWL_* classes to simplify logic.

Committed:
https://pdfium.googlesource.com/pdfium/+/3b3ce1a242f8445848d3f23d6c35ba01d7c6...
==========

[commit-bot: I haz the power, 2016-11-02 21:51:28]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/3b3ce1a242f8445848d3f23d6c35ba01d7c6...