Document user gesture state should be able to propagate over postMessage

Document user gesture state should be able to propagate over postMessage

When postMessage is called in response to a user gesture, the UserGestureToken
is put back on the stack for the onmessage handler. Ensure that the document
receiving the message is considered to have received a user gesture in that
case.

BUG=624061
TEST=http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html

Committed: https://crrev.com/73651bdf5a2913e6a7226794fa3a567542fb1a55
Cr-Commit-Position: refs/heads/master@{#429132}

[Nate Chapin, 2016-11-01 20:11:39]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 20:12:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2016-11-01 21:12:57]

japhet@chromium.org changed reviewers:
+ ojan@chromium.org, rbyers@chromium.org

[Nate Chapin, 2016-11-01 21:12:58]

I included a bit of cleanup in DocumentUserGestureToken/UserGestureToken, as
DocumentUserGestureToken is now nothing more than wrapping.

[ojan, 2016-11-01 21:20:14]

lgtm

This makes me wonder what the cases are where we ever want to have a
UserGestureToken instead of just a DocumentUserGestureToke.

[Nate Chapin, 2016-11-01 21:21:42]

On 2016/11/01 21:20:14, ojan wrote:
> lgtm
> 
> This makes me wonder what the cases are where we ever want to have a
> UserGestureToken instead of just a DocumentUserGestureToke.

We don't, but for testing (UserGestureIndicatorTest.cpp) and layering
(UserGestureToken lives in platform/, where Documents don't exist), here we are.

[Rick Byers, 2016-11-01 21:41:43]

On 2016/11/01 21:21:42, Nate Chapin wrote:
> On 2016/11/01 21:20:14, ojan wrote:
> > lgtm
> > 
> > This makes me wonder what the cases are where we ever want to have a
> > UserGestureToken instead of just a DocumentUserGestureToke.
> 
> We don't, but for testing (UserGestureIndicatorTest.cpp) and layering
> (UserGestureToken lives in platform/, where Documents don't exist), here we
are.

LGTM also

[commit-bot: I haz the power, 2016-11-01 22:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 22:00:56]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-11-01 22:04:35]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-11-01 22:05:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 22:11:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-01 22:13:46]

Description was changed from

==========
Document user gesture state should be able to propagate over postMessage

When postMessage is called in response to a user gesture, the UserGestureToken
is put back on the stack for the onmessage handler. Ensure that the document
receiving the message is considered to have received a user gesture in that
case.

BUG=624061
TEST=http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html
==========

to

==========
Document user gesture state should be able to propagate over postMessage

When postMessage is called in response to a user gesture, the UserGestureToken
is put back on the stack for the onmessage handler. Ensure that the document
receiving the message is considered to have received a user gesture in that
case.

BUG=624061
TEST=http/tests/security/frameNavigation/xss-ALLOWED-top-navigation-after-postMessage.html

Committed: https://crrev.com/73651bdf5a2913e6a7226794fa3a567542fb1a55
Cr-Commit-Position: refs/heads/master@{#429132}
==========

[commit-bot: I haz the power, 2016-11-01 22:13:48]

Patchset 1 (id:??) landed as
https://crrev.com/73651bdf5a2913e6a7226794fa3a567542fb1a55
Cr-Commit-Position: refs/heads/master@{#429132}