Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2467953003: LayerDebugInfo should not clobber trace output (Closed)

Created:
4 years, 1 month ago by Ian Vollick
Modified:
4 years, 1 month ago
Reviewers:
ajuma
CC:
chromium-reviews, Ian Vollick, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayerDebugInfo should not clobber trace output The code previously used the JSON writer incorrectly (needed to use a temporary). BUG=651455 Committed: https://crrev.com/b44373a0917b40509990fa33bfde2ca24bdd15e3 Cr-Commit-Position: refs/heads/master@{#429295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M ui/compositor/layer.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Ian Vollick
Ali, could you please sanity check this? It's a pretty trivial change. I've also confirmed ...
4 years, 1 month ago (2016-11-02 14:59:32 UTC) #6
ajuma
lgtm
4 years, 1 month ago (2016-11-02 15:08:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467953003/1
4 years, 1 month ago (2016-11-02 16:15:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 16:19:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:51:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b44373a0917b40509990fa33bfde2ca24bdd15e3
Cr-Commit-Position: refs/heads/master@{#429295}

Powered by Google App Engine
This is Rietveld 408576698