Deprecate old PublicKeyPinFailureDomain histogram

Deprecate old PublicKeyPinFailureDomain histogram

This histogram is probably never looked at by anyone and also probably
records inaccurate data because domain_ids have probably not been
constant over time. This CL deprecates the histogram, removes the code
that records it, and removes |domain_id| from PreloadResult because it's
not used for anything else.

BUG=621980
Committed: https://crrev.com/f2c5c591fb3041c49bb9d0cd2c0d2d288af8dc4e
Cr-Commit-Position: refs/heads/master@{#429121}

[estark, 2016-11-01 16:56:07]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 16:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-01 16:56:51]

estark@chromium.org changed reviewers:
+ davidben@chromium.org, holte@chromium.org

[estark, 2016-11-01 16:56:52]

davidben for net/http/transport_security_state.cc
holte for histograms.xml
Thanks!

[davidben, 2016-11-01 17:20:23]

lgtm

https://codereview.chromium.org/2467953002/diff/1/net/http/transport_security...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/2467953002/diff/1/net/http/transport_security...
net/http/transport_security_state.cc:528: !reader.Read(9, &unused_domain_id) ||
Could you file a bug to get rid of this and link it here? (Maybe for lgarron
since he's managing the list.) I'm not familiar enough with the format to know
if it'd make it more compact, but freeing up 9 bits seems valuable.

[estark, 2016-11-01 17:25:47]

https://codereview.chromium.org/2467953002/diff/1/net/http/transport_security...
File net/http/transport_security_state.cc (right):

https://codereview.chromium.org/2467953002/diff/1/net/http/transport_security...
net/http/transport_security_state.cc:528: !reader.Read(9, &unused_domain_id) ||
On 2016/11/01 17:20:22, davidben wrote:
> Could you file a bug to get rid of this and link it here? (Maybe for lgarron
> since he's managing the list.) I'm not familiar enough with the format to know
> if it'd make it more compact, but freeing up 9 bits seems valuable.

Done (bug 661206).

[Steven Holte, 2016-11-01 19:31:29]

lgtm

[estark, 2016-11-01 19:39:41]

The CQ bit was checked by estark@chromium.org

[estark, 2016-11-01 19:39:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2467953002/#ps40001
(title: "rewrap")

[commit-bot: I haz the power, 2016-11-01 19:40:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:37:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-01 21:42:39]

Description was changed from

==========
Deprecate old PublicKeyPinFailureDomain histogram

This histogram is probably never looked at by anyone and also probably
records inaccurate data because domain_ids have probably not been
constant over time. This CL deprecates the histogram, removes the code
that records it, and removes |domain_id| from PreloadResult because it's
not used for anything else.

BUG=621980
==========

to

==========
Deprecate old PublicKeyPinFailureDomain histogram

This histogram is probably never looked at by anyone and also probably
records inaccurate data because domain_ids have probably not been
constant over time. This CL deprecates the histogram, removes the code
that records it, and removes |domain_id| from PreloadResult because it's
not used for anything else.

BUG=621980

Committed: https://crrev.com/f2c5c591fb3041c49bb9d0cd2c0d2d288af8dc4e
Cr-Commit-Position: refs/heads/master@{#429121}
==========

[commit-bot: I haz the power, 2016-11-01 21:42:40]

Patchset 3 (id:??) landed as
https://crrev.com/f2c5c591fb3041c49bb9d0cd2c0d2d288af8dc4e
Cr-Commit-Position: refs/heads/master@{#429121}