Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 246793004: Fix nit which is unefficiant sequence to deleteMarkedNodes. (Closed)

Created:
6 years, 8 months ago by KhNo
Modified:
6 years, 8 months ago
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix nit which is unefficiant sequence to deleteMarkedNodes. deleteMarkedNodes need to move postion to prevent unefficiant do while loop. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172279

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/webaudio/AudioContext.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
KhNo
Please review. It has been separated.
6 years, 8 months ago (2014-04-22 12:14:49 UTC) #1
Raymond Toy
lgtm BTW, just add my chromium address for review; I don't think my google address ...
6 years, 8 months ago (2014-04-22 17:25:25 UTC) #2
KhNo
On 2014/04/22 17:25:25, Raymond Toy wrote: > lgtm > > BTW, just add my chromium ...
6 years, 8 months ago (2014-04-22 17:26:09 UTC) #3
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-22 17:26:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/246793004/1
6 years, 8 months ago (2014-04-22 17:26:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 18:12:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-22 18:12:44 UTC) #7
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-22 20:11:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/246793004/1
6 years, 8 months ago (2014-04-22 20:13:30 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 23:35:10 UTC) #10
Message was sent while issue was closed.
Change committed as 172279

Powered by Google App Engine
This is Rietveld 408576698