Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2467923002: Rename Windows and Mac AMD GPU bots. (Closed)

Created:
4 years, 1 month ago by Jamie Madill
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Rename Windows and Mac AMD GPU bots. These were sometimes calling the bots "ATI" when the name for the past several years has been "AMD". This change lines up with the src side-changes. Once it lands and the master is restarted, we can remove the old bot configs in src. BUG=639353, 649863, 641080 R=kbr@chromium.org TBR=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/130d87891c84466c4410d13e124b433d694e2acd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -2835 lines) Patch
M masters/master.chromium.gpu.fyi/slaves.cfg View 6 chunks +6 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py View 7 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/trybots.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json View 7 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json View 3 chunks +3 lines, -3 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__AMD_R5_230_.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__ATI_.json View 1 chunk +0 lines, -292 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__AMD_.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Debug__ATI_.json View 1 chunk +0 lines, -292 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__AMD_.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_10_10_Release__ATI_.json View 1 chunk +0 lines, -292 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__AMD_.json View 19 chunks +26 lines, -26 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Win7_Release__ATI_.json View 1 chunk +0 lines, -502 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__AMD_.json View 19 chunks +26 lines, -26 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__ATI_.json View 1 chunk +0 lines, -502 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_.json View 19 chunks +26 lines, -26 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_R5_230_.json View 8 chunks +10 lines, -10 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_R7_240_.json View 1 chunk +0 lines, -299 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__ATI_.json View 1 chunk +0 lines, -502 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Jamie Madill
PTAL Ken. Not sure if I need other owners.
4 years, 1 month ago (2016-11-01 15:31:05 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for putting this together. LGTM. I'll restart the chromium.gpu.fyi waterfall after this lands. Note ...
4 years, 1 month ago (2016-11-02 01:50:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467923002/1
4 years, 1 month ago (2016-11-02 01:50:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/323b8cc2f5984a10)
4 years, 1 month ago (2016-11-02 02:30:27 UTC) #6
Ken Russell (switch to Gerrit)
I'm going to take the liberty of TBR'ing the trybots.py change to dpranke@ since it's ...
4 years, 1 month ago (2016-11-02 02:49:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2467923002/1
4 years, 1 month ago (2016-11-02 02:49:38 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/130d87891c84466c4410d13e124b433d694e2acd
4 years, 1 month ago (2016-11-02 02:59:00 UTC) #13
Dirk Pranke
lgtm. feel free to post a CL adding more owners to trybots.py.
4 years, 1 month ago (2016-11-02 03:10:17 UTC) #14
Ken Russell (switch to Gerrit)
4 years, 1 month ago (2016-11-02 03:27:05 UTC) #15
Message was sent while issue was closed. 
On 2016/11/02 03:10:17, Dirk Pranke wrote:
> lgtm.
> 
> feel free to post a CL adding more owners to trybots.py.

Thanks. Posted https://codereview.chromium.org/2464293003/ .

Powered by Google App Engine
This is Rietveld 408576698