Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc

Issue 2467913002: Touch event flag should control only DOM event firing. (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into patchtoflags Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
diff --git a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
index 3800b973a166f222d7a8bf01ca346333cd0741f0..aba5fa3a0786ccc91b4a0d47682fe6f4dec09486 100644
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
@@ -257,27 +257,12 @@ UMALinuxWindowManager GetLinuxWindowManager() {
void RecordTouchEventState() {
const base::CommandLine& command_line =
*base::CommandLine::ForCurrentProcess();
- const std::string touch_enabled_switch =
- command_line.HasSwitch(switches::kTouchEvents) ?
- command_line.GetSwitchValueASCII(switches::kTouchEvents) :
- switches::kTouchEventsAuto;
-
UMATouchEventsState state;
- if (touch_enabled_switch.empty() ||
- touch_enabled_switch == switches::kTouchEventsEnabled) {
- state = UMA_TOUCH_EVENTS_ENABLED;
- } else if (touch_enabled_switch == switches::kTouchEventsAuto) {
- state = (ui::GetTouchScreensAvailability() ==
- ui::TouchScreensAvailability::ENABLED)
- ? UMA_TOUCH_EVENTS_AUTO_ENABLED
- : UMA_TOUCH_EVENTS_AUTO_DISABLED;
- } else if (touch_enabled_switch == switches::kTouchEventsDisabled) {
+ if (command_line.HasSwitch(switches::kDisableTouchEventAPI)) {
state = UMA_TOUCH_EVENTS_DISABLED;
} else {
- NOTREACHED();
- return;
+ state = UMA_TOUCH_EVENTS_ENABLED;
}
-
UMA_HISTOGRAM_ENUMERATION("Touchscreen.TouchEventsEnabled", state,
UMA_TOUCH_EVENTS_STATE_COUNT);
}

Powered by Google App Engine
This is Rietveld 408576698