Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2467913002: Touch event flag should control only DOM event firing. (Closed)
Patch Set: Deprecate the histogram. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 using flags_ui::kOsCrOSOwnerOnly; 128 using flags_ui::kOsCrOSOwnerOnly;
129 129
130 namespace about_flags { 130 namespace about_flags {
131 131
132 namespace { 132 namespace {
133 133
134 const unsigned kOsAll = kOsMac | kOsWin | kOsLinux | kOsCrOS | kOsAndroid; 134 const unsigned kOsAll = kOsMac | kOsWin | kOsLinux | kOsCrOS | kOsAndroid;
135 const unsigned kOsDesktop = kOsMac | kOsWin | kOsLinux | kOsCrOS; 135 const unsigned kOsDesktop = kOsMac | kOsWin | kOsLinux | kOsCrOS;
136 136
137 const FeatureEntry::Choice kTouchEventsChoices[] = { 137 const FeatureEntry::Choice kTouchEventsChoices[] = {
138 { IDS_GENERIC_EXPERIMENT_CHOICE_AUTOMATIC, "", "" }, 138 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, "", "" },
Rick Byers 2016/11/24 23:53:06 Does this mean that "enabled" is now the default,
139 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, 139 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kTouchEvents,
140 switches::kTouchEvents, 140 switches::kTouchEventsDisabled },
141 switches::kTouchEventsEnabled }, 141 { IDS_GENERIC_EXPERIMENT_CHOICE_AUTOMATIC, switches::kTouchEvents,
142 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 142 switches::kTouchEventsAuto }
143 switches::kTouchEvents,
144 switches::kTouchEventsDisabled }
145 }; 143 };
146 144
147 #if defined(USE_AURA) 145 #if defined(USE_AURA)
148 const FeatureEntry::Choice kOverscrollHistoryNavigationChoices[] = { 146 const FeatureEntry::Choice kOverscrollHistoryNavigationChoices[] = {
149 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, "", "" }, 147 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, "", "" },
150 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 148 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
151 switches::kOverscrollHistoryNavigation, 149 switches::kOverscrollHistoryNavigation,
152 "0" }, 150 "0" },
153 { IDS_OVERSCROLL_HISTORY_NAVIGATION_SIMPLE_UI, 151 { IDS_OVERSCROLL_HISTORY_NAVIGATION_SIMPLE_UI,
154 switches::kOverscrollHistoryNavigation, 152 switches::kOverscrollHistoryNavigation,
(...skipping 2163 matching lines...) Expand 10 before | Expand all | Expand 10 after
2318 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2316 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2319 2317
2320 const FeatureEntry* GetFeatureEntries(size_t* count) { 2318 const FeatureEntry* GetFeatureEntries(size_t* count) {
2321 *count = arraysize(kFeatureEntries); 2319 *count = arraysize(kFeatureEntries);
2322 return kFeatureEntries; 2320 return kFeatureEntries;
2323 } 2321 }
2324 2322
2325 } // namespace testing 2323 } // namespace testing
2326 2324
2327 } // namespace about_flags 2325 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698