Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 from page_sets.system_health import platforms | 5 from page_sets.system_health import platforms |
| 6 from page_sets.system_health import system_health_story | 6 from page_sets.system_health import system_health_story |
| 7 | 7 |
| 8 from page_sets.login_helpers import pinterest_login | 8 from page_sets.login_helpers import pinterest_login |
| 9 | 9 |
| 10 from telemetry import decorators | 10 from telemetry import decorators |
| (...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 129 | 129 |
| 130 | 130 |
| 131 @decorators.Disabled('mac') # crbug.com/663025 | 131 @decorators.Disabled('mac') # crbug.com/663025 |
| 132 class FlipboardDesktopStory(_NewsBrowsingStory): | 132 class FlipboardDesktopStory(_NewsBrowsingStory): |
| 133 NAME = 'browse:news:flipboard' | 133 NAME = 'browse:news:flipboard' |
| 134 URL = 'https://flipboard.com/explore' | 134 URL = 'https://flipboard.com/explore' |
| 135 IS_SINGLE_PAGE_APP = True | 135 IS_SINGLE_PAGE_APP = True |
| 136 ITEM_SELECTOR = '.cover-image' | 136 ITEM_SELECTOR = '.cover-image' |
| 137 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY | 137 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY |
| 138 | 138 |
| 139 | 139 # crbug.com/657665 for win, #crbug.com/665007 for linux |
|
aiolos (Not reviewing)
2016/11/17 22:27:13
The change is fine. But I'm confused as to why it'
aiolos (Not reviewing)
2016/11/17 22:54:06
Talked to Ned offline, we should understand why th
| |
| 140 @decorators.Disabled('win') # crbug.com/657665 | 140 @decorators.Disabled('win' ,'linux') |
| 141 class HackerNewsStory(_NewsBrowsingStory): | 141 class HackerNewsStory(_NewsBrowsingStory): |
| 142 NAME = 'browse:news:hackernews' | 142 NAME = 'browse:news:hackernews' |
| 143 URL = 'https://news.ycombinator.com' | 143 URL = 'https://news.ycombinator.com' |
| 144 ITEM_SELECTOR = '.athing .title > a' | 144 ITEM_SELECTOR = '.athing .title > a' |
| 145 | 145 |
| 146 | 146 |
| 147 class NytimesMobileStory(_NewsBrowsingStory): | 147 class NytimesMobileStory(_NewsBrowsingStory): |
| 148 """The third top website in http://www.alexa.com/topsites/category/News""" | 148 """The third top website in http://www.alexa.com/topsites/category/News""" |
| 149 NAME = 'browse:news:nytimes' | 149 NAME = 'browse:news:nytimes' |
| 150 URL = 'http://mobile.nytimes.com' | 150 URL = 'http://mobile.nytimes.com' |
| (...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 366 inner_save_function = 'document.querySelector(".nameAndIcons")' | 366 inner_save_function = 'document.querySelector(".nameAndIcons")' |
| 367 action_runner.WaitForElement(element_function=inner_save_function) | 367 action_runner.WaitForElement(element_function=inner_save_function) |
| 368 action_runner.ClickElement(element_function=inner_save_function) | 368 action_runner.ClickElement(element_function=inner_save_function) |
| 369 action_runner.Wait(1) # Wait to make navigation realistic. | 369 action_runner.Wait(1) # Wait to make navigation realistic. |
| 370 | 370 |
| 371 # Close selection. | 371 # Close selection. |
| 372 x_element_function = ('document.querySelector(' | 372 x_element_function = ('document.querySelector(' |
| 373 '".Button.borderless.close.visible")') | 373 '".Button.borderless.close.visible")') |
| 374 action_runner.ClickElement(element_function=x_element_function) | 374 action_runner.ClickElement(element_function=x_element_function) |
| 375 action_runner.Wait(1) # Wait to make navigation realistic. | 375 action_runner.Wait(1) # Wait to make navigation realistic. |
| OLD | NEW |