Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/gvr-android-sdk/README.chromium

Issue 2467873004: Linking arm and arm64 gvr static shim library (Closed)
Patch Set: Move DEPS to android Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/gvr-android-sdk/DEPS ('k') | third_party/gvr-android-sdk/common_library.aar.sha1 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/gvr-android-sdk/README.chromium
diff --git a/third_party/gvr-android-sdk/README.chromium b/third_party/gvr-android-sdk/README.chromium
index f0da5dcb59c39f5ef2e8e9866053b03d3639ca97..b7cda7f0cd17dcbaeaf3e7fae4fba1e51c1f3bfb 100644
--- a/third_party/gvr-android-sdk/README.chromium
+++ b/third_party/gvr-android-sdk/README.chromium
@@ -14,4 +14,14 @@ simple API used for creating apps inserted into Cardboard viewers, and the more
complex API for supporting Daydream-ready phones and the Daydream controller.
Local Modifications:
-None
+Only header files in NDK are used. Due to binary size concern, we have decided
+to use a static shim library instead of the shared library that comes with
+this checkout. The static libraries are downloaded from a public storage through
+gclient sync. Currently, the static libraries needs a newer version of
+common_library.aar than the one provided by this checkout. So we also download
+it from the same public storage. Once the version on github catches up, we will
+remove common_library.aar.
+All JNI calls in the static library also needs to be manually registered. So
+we have 3 jni related files. These files were generated by
+base/android/jni_generator/jni_generator.py from Java files. Modifications to
+these generated files are documented in the files.
« no previous file with comments | « third_party/gvr-android-sdk/DEPS ('k') | third_party/gvr-android-sdk/common_library.aar.sha1 » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698