Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: build/config/features.gni

Issue 2467873004: Linking arm and arm64 gvr static shim library (Closed)
Patch Set: Move DEPS to android Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index 738a1b9077ec16c4a86b9d0917a5e7ffafa2229d..9aad8645f7d4ad1a29b8fa498d1412e26e5cc16b 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -81,12 +81,10 @@ declare_args() {
# Enable WebVR support by default on Android
# Still requires command line flag to access API
- # TODO(bshe): Remove is_component_build once we can statically link gvr
- # library. Currently gvr library only has a prebuild so file which causes
- # linking issue for non component build.
+ # TODO(bshe): Enable for other architecture too. Currently we only support arm
+ # and arm64.
enable_webvr = is_android && is_component_build &&
- (current_cpu == "x86" || current_cpu == "x64" ||
- current_cpu == "arm" || current_cpu == "arm64")
+ (current_cpu == "arm" || current_cpu == "arm64")
}
# Additional dependent variables -----------------------------------------------
« no previous file with comments | « DEPS ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698