Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: build/config/features.gni

Issue 2467873004: Linking arm and arm64 gvr static shim library (Closed)
Patch Set: Final cleanup before review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index 738a1b9077ec16c4a86b9d0917a5e7ffafa2229d..3bbbdb2fafaad54224f7924dd07b7a9686ce1d42 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -81,12 +81,9 @@ declare_args() {
# Enable WebVR support by default on Android
# Still requires command line flag to access API
- # TODO(bshe): Remove is_component_build once we can statically link gvr
- # library. Currently gvr library only has a prebuild so file which causes
- # linking issue for non component build.
- enable_webvr = is_android && is_component_build &&
- (current_cpu == "x86" || current_cpu == "x64" ||
- current_cpu == "arm" || current_cpu == "arm64")
+ # TODO(bshe): Enable for other architecture too. Currently we only support arm
+ # and arm64.
+ enable_webvr = is_android && (current_cpu == "arm" || current_cpu == "arm64")
agrieve 2016/11/10 19:16:29 Can we put back is_component_build for now? Otherw
bshe 2016/11/10 20:59:25 Done. A follow up CL will simply remove the is_com
agrieve 2016/11/10 21:47:04 Right.
}
# Additional dependent variables -----------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698