third_party/gvr-android-sdk/DEPS - Issue 2467873004: Linking arm and arm64 gvr static shim library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/gvr-android-sdk/DEPS

Issue 2467873004: Linking arm and arm64 gvr static shim library (Closed)

Patch Set: Final cleanup before review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 '+base',
	Lei Zhang 2016/11/10 18:54:35 You only need base/android, right? You can add tha You only need base/android, right? You can add that, or just the 3 headers you need, and ask base/android/OWNERS for a review. bshe 2016/11/10 20:59:25 Done. Show quoted text On 2016/11/10 18:54:35, Lei Zhang (slow) wrote: > You only need base/android, right? You can add that, or just the 3 headers you > need, and ask base/android/OWNERS for a review. Done.
	3 ]

OLD	NEW