Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: build/config/features.gni

Issue 2467873004: Linking arm and arm64 gvr static shim library (Closed)
Patch Set: Final cleanup before review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 # system). 74 # system).
75 use_gconf = is_linux && !is_chromeos && !is_chromecast 75 use_gconf = is_linux && !is_chromeos && !is_chromecast
76 76
77 use_gio = is_linux && !is_chromeos && !is_chromecast 77 use_gio = is_linux && !is_chromeos && !is_chromecast
78 78
79 # Whether or not to use external popup menu. 79 # Whether or not to use external popup menu.
80 use_external_popup_menu = is_android || is_mac 80 use_external_popup_menu = is_android || is_mac
81 81
82 # Enable WebVR support by default on Android 82 # Enable WebVR support by default on Android
83 # Still requires command line flag to access API 83 # Still requires command line flag to access API
84 # TODO(bshe): Remove is_component_build once we can statically link gvr 84 # TODO(bshe): Enable for other architecture too. Currently we only support arm
85 # library. Currently gvr library only has a prebuild so file which causes 85 # and arm64.
86 # linking issue for non component build. 86 enable_webvr = is_android && (current_cpu == "arm" || current_cpu == "arm64")
agrieve 2016/11/10 19:16:29 Can we put back is_component_build for now? Otherw
bshe 2016/11/10 20:59:25 Done. A follow up CL will simply remove the is_com
agrieve 2016/11/10 21:47:04 Right.
87 enable_webvr = is_android && is_component_build &&
88 (current_cpu == "x86" || current_cpu == "x64" ||
89 current_cpu == "arm" || current_cpu == "arm64")
90 } 87 }
91 88
92 # Additional dependent variables ----------------------------------------------- 89 # Additional dependent variables -----------------------------------------------
93 90
94 # Enable the spell checker. 91 # Enable the spell checker.
95 enable_spellcheck = !is_ios 92 enable_spellcheck = !is_ios
96 93
97 # Use the operating system's spellchecker rather than hunspell. 94 # Use the operating system's spellchecker rather than hunspell.
98 use_browser_spellchecker = is_android || is_mac 95 use_browser_spellchecker = is_android || is_mac
99 96
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 132
136 enable_configuration_policy = !is_ios 133 enable_configuration_policy = !is_ios
137 134
138 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 135 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
139 # 136 #
140 # ============================================= 137 # =============================================
141 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 138 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
142 # ============================================= 139 # =============================================
143 # 140 #
144 # See comment at the top. 141 # See comment at the top.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698