Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: src/inspector/remote-object-id.h

Issue 2467853003: [inspector] migrate Runtime to new style (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/injected-script-source.js ('k') | src/inspector/remote-object-id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/remote-object-id.h
diff --git a/src/inspector/remote-object-id.h b/src/inspector/remote-object-id.h
index a32f568fb8ac0eb8768e00d98efc091d548c0144..3e6928a87e2f5f4812619a439859bfa358babdd6 100644
--- a/src/inspector/remote-object-id.h
+++ b/src/inspector/remote-object-id.h
@@ -9,7 +9,7 @@
namespace v8_inspector {
-using protocol::ErrorString;
+using protocol::Response;
class RemoteObjectIdBase {
public:
@@ -27,7 +27,7 @@ class RemoteObjectIdBase {
class RemoteObjectId final : public RemoteObjectIdBase {
public:
- static std::unique_ptr<RemoteObjectId> parse(ErrorString*, const String16&);
+ static Response parse(const String16&, std::unique_ptr<RemoteObjectId>*);
~RemoteObjectId() {}
int id() const { return m_id; }
@@ -39,8 +39,7 @@ class RemoteObjectId final : public RemoteObjectIdBase {
class RemoteCallFrameId final : public RemoteObjectIdBase {
public:
- static std::unique_ptr<RemoteCallFrameId> parse(ErrorString*,
- const String16&);
+ static Response parse(const String16&, std::unique_ptr<RemoteCallFrameId>*);
~RemoteCallFrameId() {}
int frameOrdinal() const { return m_frameOrdinal; }
« no previous file with comments | « src/inspector/injected-script-source.js ('k') | src/inspector/remote-object-id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698