Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3123)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2467833003: [Mac] Move the fullscreen toolbar style to FullscreenToolbarController (Closed)
Patch Set: fix for rsesek Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index b40f64ee8424a11b424c4d9e4685c1f67019ddb4..c9af25291dd4ad100bbe290d473c260a9e0c56e5 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -383,9 +383,6 @@ bool IsTabDetachingInFullscreenEnabled() {
extensions::ExtensionKeybindingRegistry::ALL_EXTENSIONS,
windowShim_.get()));
- PrefService* prefs = browser_->profile()->GetPrefs();
- shouldShowFullscreenToolbar_ =
- prefs->GetBoolean(prefs::kShowFullscreenToolbar);
blockLayoutSubviews_ = NO;
// We are done initializing now.
@@ -397,9 +394,8 @@ bool IsTabDetachingInFullscreenEnabled() {
- (void)dealloc {
browser_->tab_strip_model()->CloseAllTabs();
- // Explicitly release |fullscreenToolbarController_| here, as it may call back
- // to this BWC in |-dealloc|. We are required to call |-exitFullscreenMode|
- // before releasing the controller.
+ // Explicitly release |fullscreenToolbarController_| here, as it may call
+ // back to this BWC in |-dealloc|.
[fullscreenToolbarController_ exitFullscreenMode];
fullscreenToolbarController_.reset();
@@ -1828,16 +1824,7 @@ willAnimateFromState:(BookmarkBar::State)oldState
- (void)updateUIForTabFullscreen:
(ExclusiveAccessContext::TabFullscreenState)state {
DCHECK([self isInAnyFullscreenMode]);
- if (state == ExclusiveAccessContext::STATE_ENTER_TAB_FULLSCREEN) {
- [self adjustUIForSlidingFullscreenStyle:FullscreenSlidingStyle::
- OMNIBOX_TABS_NONE];
- return;
- }
-
- [self adjustUIForSlidingFullscreenStyle:
- shouldShowFullscreenToolbar_
- ? FullscreenSlidingStyle::OMNIBOX_TABS_PRESENT
- : FullscreenSlidingStyle::OMNIBOX_TABS_HIDDEN];
+ [fullscreenToolbarController_ updateToolbarStyle];
}
- (void)updateFullscreenExitBubble {
@@ -1854,17 +1841,6 @@ willAnimateFromState:(BookmarkBar::State)oldState
return NO;
}
-- (void)setFullscreenToolbarVisible:(BOOL)visible {
- if (shouldShowFullscreenToolbar_ == visible)
- return;
-
- shouldShowFullscreenToolbar_ = visible;
- [self adjustUIForSlidingFullscreenStyle:
- shouldShowFullscreenToolbar_
- ? FullscreenSlidingStyle::OMNIBOX_TABS_PRESENT
- : FullscreenSlidingStyle::OMNIBOX_TABS_HIDDEN];
-}
-
- (BOOL)isInAnyFullscreenMode {
return [self isInImmersiveFullscreen] || [self isInAppKitFullscreen];
}
@@ -1957,6 +1933,13 @@ willAnimateFromState:(BookmarkBar::State)oldState
return [focused isKindOfClass:[AutocompleteTextFieldEditor class]];
}
+- (BOOL)isFullscreenForTabContentOrExtension {
+ FullscreenController* controller =
+ browser_->exclusive_access_manager()->fullscreen_controller();
+ return controller->IsWindowFullscreenForTabOrPending() ||
+ controller->IsExtensionFullscreenOrPending();
+}
+
- (ExclusiveAccessController*)exclusiveAccessController {
return exclusiveAccessController_.get();
}
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.h ('k') | chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698